Update Netstat.yaml - fixed Bug #3417
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OSPath[2] is the wrong path. The PID is mentioned in OSPath[1]. Anyhow, this Artifact should not be used any longer as it is not using connections(). Use NetstatEnriched instead. Maybe this artifact should be deleted.
|
Thanks for this fix- actually the connections() plugin should be deprecated on Linux because it ends up calling the function from go-psutils. We have been trying to deprecate go-psutils because that library sometimes hides very expensive operations behind common APIs - so on some operating systems innocent looking calls end up being really expensive. As it is on Linux the connections() plugin ends up doing exactly the same thing as thing artfact anyway (i.e. looking through proc) but it is less flexible so this artifact is actually better. |
scudette
pushed a commit
that referenced
this pull request
Apr 25, 2024
OSPath[2] is the wrong path. The PID is mentioned in OSPath[1]. Anyhow, this Artifact should not be used any longer as it is not using connections(). Use NetstatEnriched instead. Maybe this artifact should be deleted.
scudette
pushed a commit
that referenced
this pull request
Apr 25, 2024
OSPath[2] is the wrong path. The PID is mentioned in OSPath[1]. Anyhow, this Artifact should not be used any longer as it is not using connections(). Use NetstatEnriched instead. Maybe this artifact should be deleted.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OSPath[2] is the wrong path. The PID is mentioned in OSPath[1]. Anyhow, this Artifact should not be used any longer as it is not using connections(). Use NetstatEnriched instead. Maybe this artifact should be deleted.