Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added custom json viewer implementation #3405

Merged
merged 1 commit into from
Apr 10, 2024
Merged

Added custom json viewer implementation #3405

merged 1 commit into from
Apr 10, 2024

Conversation

scudette
Copy link
Contributor

Replaced the old react-json-view with our own implementation:

  • When arrays get too large, the display shows a modal box to allow searching through them
  • When json object is too large a button allowing modal to view the whole object comfortably.
  • New component is properly themeable using classes - no need for the workaround for theming.

Replaced the old react-json-view with our own implementation:
* When arrays get too large, the display shows a modal box to allow
  searching through them
* When json object is too large a button allowing modal to view the
  whole object comfortably.
* New component is properly themeable using classes - no need for the
  workaround for theming.
@scudette scudette merged commit e43e73c into master Apr 10, 2024
3 checks passed
@scudette scudette deleted the json branch April 10, 2024 14:42
scudette added a commit that referenced this pull request Apr 10, 2024
Replaced the old react-json-view with our own implementation:
* When arrays get too large, the display shows a modal box to allow
searching through them
* When json object is too large a button allowing modal to view the
whole object comfortably.
* New component is properly themeable using classes - no need for the
workaround for theming.
scudette added a commit that referenced this pull request Apr 11, 2024
Replaced the old react-json-view with our own implementation:
* When arrays get too large, the display shows a modal box to allow
searching through them
* When json object is too large a button allowing modal to view the
whole object comfortably.
* New component is properly themeable using classes - no need for the
workaround for theming.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant