Add more info on homepage to emulator layout #698
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fire-light42
requested changes
Oct 20, 2023
Luna712
force-pushed
the
homepage-emulator
branch
from
4ec339e
to
1db92c6
Compare
Thanks! Done. |
It does some manual changes to avoid having to duplicate the entire layout for minor changes
fire-light42
approved these changes
Oct 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #662
It does some manual changes to avoid having to duplicate the entire layout for minor changes
Eventually things like this, in particular visibility might do good by using DataBinding, but for now I just did some manual layout changes (outside XML) so that we did not have to duplicate 350 lines of layout code for very few changes. We can keep the same TV layout just make some changes for proper emulator support.
Part 1 of emulator layout improvements