Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

old Amass version results in failed docker build #4

Closed
kslosek opened this issue May 7, 2020 · 2 comments
Closed

old Amass version results in failed docker build #4

kslosek opened this issue May 7, 2020 · 2 comments
Assignees

Comments

@kslosek
Copy link

kslosek commented May 7, 2020

I'm just trying this out and I really love it! I used the example Dockerfile in this repo and my build failed because the version of Amass is old. It looks like OWASP has archived the amass release v.3.4.2. I updated the Dockerfile locally to the latest v.3.5.5 and it built with no errors.

I've never contributed to another person's repo, but I forked the repo made the fix and would be happy to submit a PR for the fix.

Thanks for making this software, I've been looking for something like this for a long time.

@gorums gorums self-assigned this May 15, 2020
@gorums
Copy link
Member

gorums commented May 15, 2020

Hi @kslosek, thanks for the feedback, I'll update amass version ASAP or If you did the update you can send the PR and I'll test and approve it.

Thanks

@gorums
Copy link
Member

gorums commented May 20, 2020

Hey @kslosek, I merged a PR with the amass fix. thanks for the feedback

@gorums gorums closed this as completed May 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants