Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unwanted HTML tags in Merge button pop-up #66

Closed
offmindby opened this issue Aug 2, 2018 · 1 comment
Closed

Unwanted HTML tags in Merge button pop-up #66

offmindby opened this issue Aug 2, 2018 · 1 comment

Comments

@offmindby
Copy link

offmindby commented Aug 2, 2018

Bitbucket Server 4.8.3
Using External Merge Check Hook for pull requests
Simply bash script checks some points and exit with code 1. Also some information is printed into standard output.
So, the Merge button is disabled as it should be and shows this output as a pop-up in brow
![screenshot from 2018-07-31 16-30-38]
ser. This pop-up contains some HTML tags which are added by Bitbucket, but couldn't be rendered by a browser.
I've checked Google Chrome 68.0.3440.84-1 and Firefox
To reproduce:

  • create a bash script which has any output and exit with code 1
  • add this script as a hook for External Merge Check Hook
  • create a pull request
  • open a pull requests and click on a Merge button(which should be disabled)

(https://user-images.githubusercontent.com/5739685/43574231-5183276e-964c-11e8-925a-6c27106d0dad.png)

@seletskiy
Copy link
Member

#46

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants