Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Crash in case which call serViewControllers at the second time. #3

Closed
yshrkt opened this issue Jan 30, 2015 · 2 comments
Closed

Crash in case which call serViewControllers at the second time. #3

yshrkt opened this issue Jan 30, 2015 · 2 comments
Labels
bug
Milestone
1.0.4

Comments

@yshrkt
Copy link
Contributor

yshrkt commented Jan 30, 2015

Crash in case which called setViewController at the second time in order to change menuBarController's viewControllers.

NSArray* viewControllersFirst = @[vc1a, vc2a, vc3a];
[menuBarController setViewControllers:viewControllers];
...
// Already shows viewControllers in menuBarController
...
// In certain timing,  reset viewControllsers
NSArray* viewControllersSecond = @[vc1b, vc2b, vc3b];
[menuBarController setViewControllers:viewControllers]
// Crash!!
@yshrkt yshrkt added the bug label Jan 30, 2015
@yshrkt yshrkt added this to the 1.0.4 milestone Jan 30, 2015
yshrkt added a commit to yshrkt/RMPScrollingMenuBarController that referenced this issue Jan 30, 2015
@yshrkt
Fixes the crash by the issue recruit-mp#3.
6622570 
Fixes the crash in case which call serViewControllers at the second
time.
@yshrkt
Copy link
Contributor Author

yshrkt commented Jan 30, 2015

Pull request #4

yshrkt pushed a commit that referenced this issue Jan 30, 2015
Merge pull request #4 from yshrkt/master
6818754 
Fixes the crash by the issue #3.
@yshrkt
Copy link
Contributor Author

yshrkt commented Jan 30, 2015

Merged pull request.

@yshrkt yshrkt closed this as completed Jan 30, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
1.0.4
Development

No branches or pull requests
1 participant
@yshrkt