Make use of getArgs()

[TomasVotruba]

Ref rectorphp/rector-src#3822

[samsonasik]

No, getArgs() throw warning too early, see

https://github.com/nikic/PHP-Parser/blob/0ffddce52d816f72d0efc4d9b02e276d3309ef01/lib/PhpParser/Node/Expr/CallLike.php#L36

[TomasVotruba]

I see. I think these asserts are never executed, never came across it.

[TomasVotruba]

I've added a fixture to covert it with (...) and is passed. Could you share a PR with failing test fixture?

I'll merge this, so we can iterate to improve.

[samsonasik]

while downgrade rule always downgrade DowngradeFirstClassCallableSyntaxRector early, this may cause jump rule which the args still a first class callable, that's wil cause error:

PHP Warning:  Uncaught AssertionError: assert(!$this->isFirstClassCallable()) in php shell code:1

[samsonasik]

Assert is show or not depends on zend.assertions. setting, which default OFF on our CI.

[samsonasik]

this will show error when enable zend.assertion in CI https://www.php.net/manual/en/ini.core.php#ini.zend.assertions

[samsonasik]

Here the example setting assertion setting in console:

# disable
php > ini_set('zend.assertions', 0);
php > assert(true === false);

# enable
php > ini_set('zend.assertions', 1);
php > assert(true === false);
PHP Warning:  Uncaught AssertionError: assert(true === false) in php shell code:1
Stack trace:
#0 php shell code(1): assert(false, 'assert(true ===...')
#1 {main}
  thrown in php shell code on line 1

Warning: Uncaught AssertionError: assert(true === false) in php shell code:1
Stack trace:
#0 php shell code(1): assert(false, 'assert(true ===...')
#1 {main}
  thrown in php shell code on line 1
``

[samsonasik]

Ok, isFirstCallable() already called on shouldSkip() method, so it works

rector-downgrade-php/rules/DowngradePhp70/Rector/Expression/DowngradeDefineArrayConstantRector.php

Lines 86 to 88 in 86a937c

	if ($funcCall->isFirstClassCallable()) {
	return true;
	}