Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[PHPUnit 10] Handle DataProvider attribute not included on use PHPUnitSetList::PHPUNIT_100 #300

Merged
merged 3 commits into from
Dec 26, 2023
Merged

[PHPUnit 10] Handle DataProvider attribute not included on use PHPUnitSetList::PHPUNIT_100 #300

merged 3 commits into from
Dec 26, 2023

Conversation

samsonasik
Copy link
Member

@samsonasik samsonasik mentioned this pull request Dec 26, 2023
Closed
@samsonasik
Copy link
Member Author

@rpkamp the issue is due to the class not extending \PHPUnit\Framework\TestCase, change to extends it solve it, tested with this PR.

@TomasVotruba I am merging it as future proven for test.

@samsonasik samsonasik merged commit e5120ff into main Dec 26, 2023
5 checks passed
@samsonasik samsonasik deleted the dataprove branch December 26, 2023 14:34
@TomasVotruba
Copy link
Member

Thank you 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Rector fails to convert dataProvider annotation to #[DataProvider] attribute for PHPUnit 10
3 participants
@samsonasik @TomasVotruba @actions-user