-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reimplement WithConsecutiveRector (#311) #313
Conversation
could you run:
to make CI green? Thank you. |
Thanks for the proposal. It's quite difficult to review the match to switch change. We actully promote newer PHP and PHPUnit 10 is already on PHP 8+, so match is a valid option. Could you keep the Thanks |
@TomasVotruba When can I expect a review? |
tests/Rector/StmtsAwareInterface/WithConsecutiveRector/Fixture/exclude_will.php.inc
Outdated
Show resolved
Hide resolved
tests/Rector/StmtsAwareInterface/WithConsecutiveRector/Fixture/exclude_will_return_map.php.inc
Outdated
Show resolved
Hide resolved
...ector/StmtsAwareInterface/WithConsecutiveRector/Fixture/exclude_will_return_callback.php.inc
Outdated
Show resolved
Hide resolved
Thanks for reviews @samsonasik 👍 Let's give this a go 👏 |
#311 I tried to reimplement WithConsecutiveRector because the previous implementation is incorrect.
I think i need to refactor the code.
It's my first time using phpparser and contributing on github. I am open to suggestions for improvements. :)