[TypeDeclaration] Decouple AddParamTypeFromPropertyTypeRector (#3109)

Co-authored-by: GitHub Action <action@github.com>

build/target-repository/docs/rector_rules_overview.md

@@ -1,4 +1,4 @@
-# 404 Rules Overview
+# 405 Rules Overview
 
 <br>
 
@@ -64,7 +64,7 @@
 
 - [Transform](#transform) (34)
 
-- [TypeDeclaration](#typedeclaration) (32)
+- [TypeDeclaration](#typedeclaration) (33)
 
 - [Visibility](#visibility) (3)
 
@@ -8869,6 +8869,27 @@ return static function (RectorConfig $rectorConfig): void {
 
 <br>
 
+### AddParamTypeFromPropertyTypeRector
+
+Adds param type declaration based on property type the value is assigned to PHPUnit provider return type declaration
+
+- class: [`Rector\TypeDeclaration\Rector\ClassMethod\AddParamTypeFromPropertyTypeRector`](../rules/TypeDeclaration/Rector/ClassMethod/AddParamTypeFromPropertyTypeRector.php)
+
+```diff
+ final class SomeClass
+ {
+     private string $name;
+
+-    public function setName($name)
++    public function setName(string $name)
+     {
+         $this->name = $name;
+     }
+ }
+```
+
+<br>
+
 ### AddParamTypeSplFixedArrayRector
 
 Add exact fixed array type in known cases

config/set/type-declaration.php

@@ -9,6 +9,7 @@
 use Rector\TypeDeclaration\Rector\ClassMethod\AddArrayReturnDocTypeRector;
 use Rector\TypeDeclaration\Rector\ClassMethod\AddMethodCallBasedStrictParamTypeRector;
 use Rector\TypeDeclaration\Rector\ClassMethod\AddParamTypeBasedOnPHPUnitDataProviderRector;
+use Rector\TypeDeclaration\Rector\ClassMethod\AddParamTypeFromPropertyTypeRector;
 use Rector\TypeDeclaration\Rector\ClassMethod\AddReturnTypeDeclarationBasedOnParentClassMethodRector;
 use Rector\TypeDeclaration\Rector\ClassMethod\AddVoidReturnTypeWhereNoReturnRector;
 use Rector\TypeDeclaration\Rector\ClassMethod\ArrayShapeFromConstantArrayReturnRector;
@@ -64,5 +65,6 @@
         ParamTypeByParentCallTypeRector::class,
         AddParamTypeSplFixedArrayRector::class,
         AddParamTypeBasedOnPHPUnitDataProviderRector::class,
+        AddParamTypeFromPropertyTypeRector::class,
     ]);
 };

rules-tests/TypeDeclaration/Rector/FunctionLike/ParamTypeDeclarationRector/PropertyTypeParamTypeDeclarationRectorTest.php → rules-tests/TypeDeclaration/Rector/ClassMethod/AddParamTypeFromPropertyTypeRector/AddParamTypeFromPropertyTypeRectorTest.php

@@ -2,12 +2,12 @@
 
 declare(strict_types=1);
 
-namespace Rector\Tests\TypeDeclaration\Rector\FunctionLike\ParamTypeDeclarationRector;
+namespace Rector\Tests\TypeDeclaration\Rector\ClassMethod\AddParamTypeFromPropertyTypeRector;
 
 use Iterator;
 use Rector\Testing\PHPUnit\AbstractRectorTestCase;
 
-final class PropertyTypeParamTypeDeclarationRectorTest extends AbstractRectorTestCase
+final class AddParamTypeFromPropertyTypeRectorTest extends AbstractRectorTestCase
 {
     /**
      * @dataProvider provideData()
@@ -17,13 +17,16 @@ public function test(string $filePath): void
         $this->doTestFile($filePath);
     }
 
+    /**
+     * @return Iterator<array<string>>
+     */
     public function provideData(): Iterator
     {
-        return $this->yieldFilesFromDirectory(__DIR__ . '/FixturePropertyType');
+        return $this->yieldFilesFromDirectory(__DIR__ . '/Fixture');
     }
 
     public function provideConfigFilePath(): string
     {
-        return __DIR__ . '/config/typed_properties.php';
+        return __DIR__ . '/config/configured_rule.php';
     }
 }

rules-tests/TypeDeclaration/Rector/ClassMethod/AddParamTypeFromPropertyTypeRector/Fixture/fixture.php.inc

@@ -0,0 +1,31 @@
+<?php
+
+namespace Rector\Tests\TypeDeclaration\Rector\ClassMethod\AddParamTypeFromPropertyTypeRector\Fixture;
+
+final class SomeClass
+{
+    private int $number;
+
+    public function setValue($number)
+    {
+        $this->number = $number;
+    }
+}
+
+?>
+-----
+<?php
+
+namespace Rector\Tests\TypeDeclaration\Rector\ClassMethod\AddParamTypeFromPropertyTypeRector\Fixture;
+
+final class SomeClass
+{
+    private int $number;
+
+    public function setValue(int $number)
+    {
+        $this->number = $number;
+    }
+}
+
+?>

rules-tests/TypeDeclaration/Rector/ClassMethod/AddParamTypeFromPropertyTypeRector/Fixture/nullable_property.php.inc

@@ -0,0 +1,37 @@
+<?php
+
+namespace Rector\Tests\TypeDeclaration\Rector\ClassMethod\AddParamTypeFromPropertyTypeRector\Fixture;
+
+final class NullableProperty
+{
+    /**
+     * @var int[]|null
+     */
+    public ?array $bar;
+
+    public function setBar($bar): void
+    {
+        $this->bar = $bar;
+    }
+}
+
+?>
+-----
+<?php
+
+namespace Rector\Tests\TypeDeclaration\Rector\ClassMethod\AddParamTypeFromPropertyTypeRector\Fixture;
+
+final class NullableProperty
+{
+    /**
+     * @var int[]|null
+     */
+    public ?array $bar;
+
+    public function setBar(?array $bar): void
+    {
+        $this->bar = $bar;
+    }
+}
+
+?>