-
-
Notifications
You must be signed in to change notification settings - Fork 336
Commit
- Loading branch information
There are no files selected for viewing
Original file line number | Diff line number | Diff line change | ||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
|
@@ -53,10 +53,6 @@ jobs: | |||||||||||||||
working-directory: ${{ matrix.directory }} | ||||||||||||||||
|
||||||||||||||||
# run e2e test | ||||||||||||||||
- run: php ../e2eTestRunner.php -c custom/config/rector.php | ||||||||||||||||
working-directory: ${{ matrix.directory }} | ||||||||||||||||
if: ${{ matrix.directory == 'e2e/parallel-custom-config' }} | ||||||||||||||||
|
||||||||||||||||
This comment has been minimized.
Sorry, something went wrong.
This comment has been minimized.
Sorry, something went wrong.
samsonasik
Member
|
if (isset($argv[1]) && $argv[1] === '-c') { | |
$e2eCommand .= ' -c ' . $argv[2]; | |
} | |
if (isset($argv[1]) && $argv[1] === '--config') { | |
$e2eCommand .= ' --config ' . $argv[2]; | |
} |
This comment has been minimized.
This comment has been minimized.
Sorry, something went wrong.
TomasVotruba
Aug 9, 2022
•
edited
Author
Member
edited
This is only testing the shortcut in symfony/console works, that out of our scope.
I'm trying to debug failing test and this makes it unnecessary complicated.
This comment has been minimized.
This comment has been minimized.
Sorry, something went wrong.
samsonasik
Aug 9, 2022
Member
@TomasVotruba previously, there is issue with parallel when -c
vs --config
which not works on -c
see original PR #1620
This comment has been minimized.
This comment has been minimized.
Sorry, something went wrong.
TomasVotruba
Aug 9, 2022
Author
Member
I see. I'll return it and link this PR to give it more context then 👍
@TomasVotruba no, it is not duplicated, the
-c
vs--config
is registered both on purpose...