Skip to content

Commit

Permalink
remove duplicated test
Browse files Browse the repository at this point in the history
  • Loading branch information
TomasVotruba committed Aug 9, 2022
1 parent c8c3e82 commit 17257b8
Showing 1 changed file with 0 additions and 4 deletions.
4 changes: 0 additions & 4 deletions .github/workflows/e2e.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -53,10 +53,6 @@ jobs:
working-directory: ${{ matrix.directory }}

# run e2e test
- run: php ../e2eTestRunner.php -c custom/config/rector.php
working-directory: ${{ matrix.directory }}
if: ${{ matrix.directory == 'e2e/parallel-custom-config' }}

This comment has been minimized.

Copy link
@samsonasik

samsonasik Aug 9, 2022

Member

@TomasVotruba no, it is not duplicated, the -c vs --config is registered both on purpose...

This comment has been minimized.

Copy link
@samsonasik

samsonasik Aug 9, 2022

Member

@TomasVotruba the e2e test script is test both -c and --config, so this should be exists

if (isset($argv[1]) && $argv[1] === '-c') {
$e2eCommand .= ' -c ' . $argv[2];
}
if (isset($argv[1]) && $argv[1] === '--config') {
$e2eCommand .= ' --config ' . $argv[2];
}

This comment has been minimized.

Copy link
@TomasVotruba

TomasVotruba Aug 9, 2022

Author Member

This is only testing the shortcut in symfony/console works, that out of our scope.
I'm trying to debug failing test and this makes it unnecessary complicated.

This comment has been minimized.

Copy link
@samsonasik

samsonasik Aug 9, 2022

Member

@TomasVotruba previously, there is issue with parallel when -c vs --config which not works on -c see original PR #1620

This comment has been minimized.

Copy link
@TomasVotruba

TomasVotruba Aug 9, 2022

Author Member

I see. I'll return it and link this PR to give it more context then 👍

- run: php ../e2eTestRunner.php --config custom/config/rector.php
working-directory: ${{ matrix.directory }}
if: ${{ matrix.directory == 'e2e/parallel-custom-config' }}
Expand Down

0 comments on commit 17257b8

Please sign in to comment.