[e2e][parallel] Allow set custom config on Parallel#1620
Merged
TomasVotruba merged 9 commits intomainfrom Jan 4, 2022
Merged
Conversation
a3174e6 to
d2daa53
Compare
5b9c64d to
a1c215f
Compare
Member
Author
|
It seems $input->hasOption(Option::CONFIG)return true on |
Member
Author
|
I updated e2e script to test passed |
Member
Author
|
Fixed 🎉 |
Member
Author
|
All checks have passed 🎉 @TomasVotruba it is ready for review. Next PR is to apply |
TomasVotruba
reviewed
Jan 4, 2022
Comment on lines
-48
to
60
| # run e2e test | ||
| - | ||
| run: php ../e2eTestRunner.php | ||
| - run: php ../e2eTestRunner.php -c custom/config/rector.php | ||
| working-directory: ${{ matrix.directory }} | ||
| if: ${{ matrix.directory == 'e2e/parallel-custom-config' }} | ||
|
|
||
| - run: php ../e2eTestRunner.php --config custom/config/rector.php | ||
| working-directory: ${{ matrix.directory }} | ||
| if: ${{ matrix.directory == 'e2e/parallel-custom-config' }} | ||
|
|
||
| - run: php ../e2eTestRunner.php | ||
| working-directory: ${{ matrix.directory }} | ||
| if: ${{ matrix.directory != 'e2e/parallel-custom-config' }} | ||
|
|
Member
There was a problem hiding this comment.
We could put the "if" right into the matrix:
matrix:
php_version: ['8.1']
actions:
-
directory: e2e/template-extends
runner: php ../e2eTestRunner.php -c custom/config/rector.php
Member
There was a problem hiding this comment.
I'm merging this PR to keep original fix and this syntax improvement separated 👍
Member
|
Thank you 👍 |
Member
Author
|
@TomasVotruba here the original PR why |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@TomasVotruba this seems a reason why downgrade scoper build can't work via Parallel, it because it can't read config via
--cbecause the script is target with--config:rector-src/build/downgrade-rector.sh
Line 26 in f900476
This PR apply:
1. updated
WorkerCommandLineFactoryto append config for it based on option 'config' https://github.com/rectorphp/rector-src/pull/1620/files#diff-1c7bf20096eedf4dac69e487b7d1e3ad3f9cc122b98d54e145c2f463a2facab9If no
--configinput, it will got config fromrector.php.2. Add
e2etests for its demo with pass custom config into input.