Deprecated and remove AddArrayParamDocTypeRector to work with strict …

…type declarations only (#3112)

* misc

* simplify param type infer

* Deprecated and remove AddArrayParamDocTypeRector that works with docblock unreliable types and spread weak types, use specific split types instead

* remove NullableParamNamespaced as depends on deprecated rule

* use 1.13 phpdoc-parser as higher breaking

composer.json

@@ -16,7 +16,7 @@
         "nette/utils": "^3.2.8",
         "nikic/php-parser": "^4.15.2",
         "ondram/ci-detector": "^4.1",
-        "phpstan/phpdoc-parser": "^1.13",
+        "phpstan/phpdoc-parser": "1.13.*",
         "phpstan/phpstan": "^1.9.2",
         "phpstan/phpstan-phpunit": "^1.2.2",
         "react/event-loop": "^1.3",

easy-ci.php

@@ -44,7 +44,6 @@
 use Rector\Testing\PHPUnit\AbstractTestCase;
 use Rector\TypeDeclaration\Contract\PHPStan\TypeWithClassTypeSpecifierInterface;
 use Rector\TypeDeclaration\Contract\TypeInferer\ReturnTypeInfererInterface;
-use Rector\TypeDeclaration\NodeAnalyzer\ControllerRenderMethodAnalyzer;
 use Symfony\Component\Console\Application;
 use Symfony\Component\Console\Command\Command;
 use Symplify\EasyCI\Config\EasyCIConfig;
@@ -60,7 +59,6 @@
         RectorInterface::class,
         TypeToCallReflectionResolverInterface::class,
         // used in another Rector package
-        ControllerRenderMethodAnalyzer::class,
         ReturnTypeInfererInterface::class,
         FileProcessorInterface::class,
         ClassNameImportSkipVoterInterface::class,

phpstan.neon

@@ -787,3 +787,6 @@ parameters:
 
         # false positive
         - '#Method Rector\\TypeDeclaration\\Rector\\ClassMethod\\AddParamTypeBasedOnPHPUnitDataProviderRector\:\:resolveDataProviderPhpDocTagNode\(\) should return PHPStan\\PhpDocParser\\Ast\\PhpDoc\\PhpDocTagNode\|null but returns PHPStan\\PhpDocParser\\Ast\\Node\|null#'
+
+        # on purpose, as rule it about to be removed
+        - '#Class "Rector\\TypeDeclaration\\Rector\\ClassMethod\\AddArrayParamDocTypeRector" is missing @see annotation with test case class reference#'