Remove deprecated ParamTypeDeclarationRector, that treated docs as st…

…rict types to keep type declaration set reliable (#3111)

build/target-repository/docs/rector_rules_overview.md

@@ -9152,30 +9152,13 @@ Change `@param` types to type declarations if not a BC-break
 - class: [`Rector\TypeDeclaration\Rector\FunctionLike\ParamTypeDeclarationRector`](../rules/TypeDeclaration/Rector/FunctionLike/ParamTypeDeclarationRector.php)
 
 ```diff
- abstract class VendorParentClass
- {
-     /**
-      * @param int $number
-      */
-     public function keep($number)
-     {
-     }
- }
-
- final class ChildClass extends VendorParentClass
+ final class SomeClass
  {
-     /**
-      * @param int $number
-      */
-     public function keep($number)
-     {
-     }
-
 -    /**
 -     * @param int $number
 -     */
--    public function change($number)
-+    public function change(int $number)
+-    public function run($number)
++    public function run(int $number)
      {
      }
  }

config/set/type-declaration.php

@@ -24,7 +24,6 @@
 use Rector\TypeDeclaration\Rector\ClassMethod\ReturnTypeFromStrictTypedPropertyRector;
 use Rector\TypeDeclaration\Rector\Closure\AddClosureReturnTypeRector;
 use Rector\TypeDeclaration\Rector\FunctionLike\AddParamTypeSplFixedArrayRector;
-use Rector\TypeDeclaration\Rector\FunctionLike\ParamTypeDeclarationRector;
 use Rector\TypeDeclaration\Rector\FunctionLike\ReturnTypeDeclarationRector;
 use Rector\TypeDeclaration\Rector\Param\ParamTypeFromStrictTypedPropertyRector;
 use Rector\TypeDeclaration\Rector\Property\PropertyTypeDeclarationRector;
@@ -36,7 +35,6 @@
 
 return static function (RectorConfig $rectorConfig): void {
     $rectorConfig->rules([
-        ParamTypeDeclarationRector::class,
         ReturnTypeDeclarationRector::class,
         PropertyTypeDeclarationRector::class,
         AddClosureReturnTypeRector::class,

easy-ci.php

@@ -43,8 +43,8 @@
 use Rector\StaticTypeMapper\Contract\PhpParser\PhpParserNodeMapperInterface;
 use Rector\Testing\PHPUnit\AbstractTestCase;
 use Rector\TypeDeclaration\Contract\PHPStan\TypeWithClassTypeSpecifierInterface;
-use Rector\TypeDeclaration\Contract\TypeInferer\ParamTypeInfererInterface;
 use Rector\TypeDeclaration\Contract\TypeInferer\ReturnTypeInfererInterface;
+use Rector\TypeDeclaration\NodeAnalyzer\ControllerRenderMethodAnalyzer;
 use Symfony\Component\Console\Application;
 use Symfony\Component\Console\Command\Command;
 use Symplify\EasyCI\Config\EasyCIConfig;
@@ -59,7 +59,8 @@
         Application::class,
         RectorInterface::class,
         TypeToCallReflectionResolverInterface::class,
-        ParamTypeInfererInterface::class,
+        // used in another Rector package
+        ControllerRenderMethodAnalyzer::class,
         ReturnTypeInfererInterface::class,
         FileProcessorInterface::class,
         ClassNameImportSkipVoterInterface::class,

packages/VendorLocker/ParentClassMethodTypeOverrideGuard.php

@@ -12,20 +12,16 @@
 use PHPStan\Type\MixedType;
 use PHPStan\Type\Type;
 use Rector\Core\FileSystem\FilePathHelper;
-use Rector\Core\PhpParser\AstResolver;
 use Rector\Core\Reflection\ReflectionResolver;
 use Rector\Core\ValueObject\MethodName;
 use Rector\NodeNameResolver\NodeNameResolver;
 use Rector\NodeTypeResolver\TypeComparator\TypeComparator;
 use Rector\StaticTypeMapper\StaticTypeMapper;
-use Rector\TypeDeclaration\TypeInferer\ParamTypeInferer;
 
 final class ParentClassMethodTypeOverrideGuard
 {
     public function __construct(
         private readonly NodeNameResolver $nodeNameResolver,
-        private readonly AstResolver $astResolver,
-        private readonly ParamTypeInferer $paramTypeInferer,
         private readonly ReflectionResolver $reflectionResolver,
         private readonly TypeComparator $typeComparator,
         private readonly StaticTypeMapper $staticTypeMapper,
@@ -93,34 +89,6 @@ public function hasParentClassMethod(ClassMethod $classMethod): bool
         return $this->getParentClassMethod($classMethod) instanceof MethodReflection;
     }
 
-    public function hasParentClassMethodDifferentType(ClassMethod $classMethod, int $position, Type $currentType): bool
-    {
-        if ($classMethod->isPrivate()) {
-            return false;
-        }
-
-        $methodReflection = $this->getParentClassMethod($classMethod);
-        if (! $methodReflection instanceof MethodReflection) {
-            return false;
-        }
-
-        $classMethod = $this->astResolver->resolveClassMethodFromMethodReflection($methodReflection);
-        if (! $classMethod instanceof ClassMethod) {
-            return false;
-        }
-
-        if ($classMethod->isPrivate()) {
-            return false;
-        }
-
-        if (! isset($classMethod->params[$position])) {
-            return false;
-        }
-
-        $inferedType = $this->paramTypeInferer->inferParam($classMethod->params[$position]);
-        return $inferedType::class !== $currentType::class;
-    }
-
     public function getParentClassMethod(ClassMethod $classMethod): ?MethodReflection
     {
         $classReflection = $this->reflectionResolver->resolveClassReflection($classMethod);