remove is cache debug

rectorphp · Jun 22, 2021 · 77a90c5 · 77a90c5
1 parent c2ce610
commit 77a90c5
Show file tree

Hide file tree

Showing 6 changed files with 4 additions and 45 deletions.
diff --git a/packages/NodeTypeResolver/PHPStan/Scope/PHPStanNodeScopeResolver.php b/packages/NodeTypeResolver/PHPStan/Scope/PHPStanNodeScopeResolver.php
@@ -162,8 +162,6 @@ private function reportCacheDebugAndSaveDependentFiles(SmartFileInfo $smartFileI
             return;
         }
 
-        $this->reportCacheDebug($smartFileInfo, $dependentFiles);
-
         // save for cache
         $this->changedFilesDetector->addFileWithDependencies($smartFileInfo, $dependentFiles);
     }
@@ -180,25 +178,4 @@ private function resolveClassName(Class_ | Interface_ | Trait_ $classLike): stri
 
         return $classLike->name->toString();
     }
-
-    /**
-     * @param string[] $dependentFiles
-     */
-    private function reportCacheDebug(SmartFileInfo $smartFileInfo, array $dependentFiles): void
-    {
-        if (! $this->configuration->isCacheDebug()) {
-            return;
-        }
-        $message = sprintf(
-            '[debug] %d dependencies for "%s" file',
-            count($dependentFiles),
-            $smartFileInfo->getRealPath()
-        );
-
-        $this->symfonyStyle->note($message);
-
-        if ($dependentFiles !== []) {
-            $this->symfonyStyle->listing($dependentFiles);
-        }
-    }
 }
diff --git a/src/Autoloading/AdditionalAutoloader.php b/src/Autoloading/AdditionalAutoloader.php
@@ -41,10 +41,6 @@ public function autoloadInput(InputInterface $input): void
     public function autoloadPaths(): void
     {
         $autoloadPaths = $this->parameterProvider->provideArrayParameter(Option::AUTOLOAD_PATHS);
-        if ($autoloadPaths === []) {
-            return;
-        }
-
         $this->dynamicSourceLocatorDecorator->addPaths($autoloadPaths);
     }
 }
diff --git a/src/Configuration/Configuration.php b/src/Configuration/Configuration.php
@@ -21,8 +21,6 @@ final class Configuration
 
     private string $outputFormat;
 
-    private bool $isCacheDebug = false;
-
     private bool $isCacheEnabled = false;
 
     /**
@@ -59,7 +57,6 @@ public function resolveFromInput(InputInterface $input): void
 
         $this->showProgressBar = $this->canShowProgressBar($input);
         $this->showDiffs = ! (bool) $input->getOption(Option::NO_DIFFS);
-        $this->isCacheDebug = (bool) $input->getOption(Option::CACHE_DEBUG);
 
         $this->outputFormat = (string) $input->getOption(Option::OUTPUT_FORMAT);
 
@@ -87,10 +84,6 @@ public function isDryRun(): bool
 
     public function shouldShowProgressBar(): bool
     {
-        if ($this->isCacheDebug) {
-            return false;
-        }
-
         return $this->showProgressBar;
     }
 
@@ -99,11 +92,6 @@ public function shouldClearCache(): bool
         return $this->shouldClearCache;
     }
 
-    public function isCacheDebug(): bool
-    {
-        return $this->isCacheDebug;
-    }
-
     public function isCacheEnabled(): bool
     {
         return $this->isCacheEnabled;

diff --git a/src/Configuration/Option.php b/src/Configuration/Option.php
@@ -73,11 +73,6 @@ final class Option
      */
     public const ENABLE_CACHE = 'enable_cache';
 
-    /**
-     * @var string
-     */
-    public const CACHE_DEBUG = 'cache-debug';
-
     /**
      * @var string
      */

diff --git a/src/Console/Command/ProcessCommand.php b/src/Console/Command/ProcessCommand.php
@@ -90,7 +90,6 @@ protected function configure(): void
             'Hide diffs of changed files. Useful e.g. for nicer CI output.'
         );
 
-        $this->addOption(Option::CACHE_DEBUG, null, InputOption::VALUE_NONE, 'Debug changed file cache');
         $this->addOption(Option::CLEAR_CACHE, null, InputOption::VALUE_NONE, 'Clear unchaged files cache');
     }
 

diff --git a/src/StaticReflection/DynamicSourceLocatorDecorator.php b/src/StaticReflection/DynamicSourceLocatorDecorator.php
@@ -26,6 +26,10 @@ public function __construct(
      */
     public function addPaths(array $paths): void
     {
+        if ($paths === []) {
+            return;
+        }
+
         $files = $this->fileSystemFilter->filterFiles($paths);
         $this->dynamicSourceLocatorProvider->addFiles($files);