[Php82] Skip ReadOnlyClassRector on has parent non-readonly class (#3169

)

Fixes rectorphp/rector#7646

rules-tests/Php82/Rector/Class_/ReadOnlyClassRector/Fixture/skip_if_class_extends_from_a_class_that_is_not_readonly.php.inc

@@ -0,0 +1,15 @@
+<?php
+
+namespace Rector\Tests\Php82\Rector\Class_\ReadOnlyClassRector\Fixture;
+
+class Foo
+{
+
+}
+
+final class SkipIfClassExtendsFromAClassThatIsNotReadonly extends Foo
+{
+    public function __construct()
+    {
+    }
+}

rules/Php82/Rector/Class_/ReadOnlyClassRector.php

@@ -9,8 +9,10 @@
 use PhpParser\Node\Stmt\Class_;
 use PhpParser\Node\Stmt\ClassMethod;
 use PhpParser\Node\Stmt\Property;
+use PHPStan\Reflection\ClassReflection;
 use Rector\Core\NodeAnalyzer\ClassAnalyzer;
 use Rector\Core\Rector\AbstractRector;
+use Rector\Core\Reflection\ReflectionResolver;
 use Rector\Core\ValueObject\MethodName;
 use Rector\Core\ValueObject\PhpVersionFeature;
 use Rector\Core\ValueObject\Visibility;
@@ -31,7 +33,8 @@ final class ReadOnlyClassRector extends AbstractRector implements MinPhpVersionI
     public function __construct(
         private readonly ClassAnalyzer $classAnalyzer,
         private readonly VisibilityManipulator $visibilityManipulator,
-        private readonly PhpAttributeAnalyzer $phpAttributeAnalyzer
+        private readonly PhpAttributeAnalyzer $phpAttributeAnalyzer,
+        private readonly ReflectionResolver $reflectionResolver
     ) {
     }
 
@@ -163,6 +166,18 @@ private function shouldSkipClass(Class_ $class): bool
             return true;
         }
 
+        $classReflection = $this->reflectionResolver->resolveClassReflection($class);
+        if (! $classReflection instanceof ClassReflection) {
+            return true;
+        }
+
+        $parents = $classReflection->getParents();
+        foreach ($parents as $parent) {
+            if (! $parent->isReadOnly()) {
+                return true;
+            }
+        }
+
         return $this->phpAttributeAnalyzer->hasPhpAttribute($class, AttributeName::ALLOW_DYNAMIC_PROPERTIES);
     }