[NodeTypeResolver] Reduce AstResolver usage on ArrayTypeAnalyzer (#5096)

rectorphp · Sep 30, 2023 · 8a3fddf · 8a3fddf
1 parent 3c1035b
commit 8a3fddf
Showing 1 changed file with 1 addition and 23 deletions.
diff --git a/packages/NodeTypeResolver/TypeAnalyzer/ArrayTypeAnalyzer.php b/packages/NodeTypeResolver/TypeAnalyzer/ArrayTypeAnalyzer.php
@@ -147,35 +147,13 @@ private function isPropertyFetchWithArrayDefault(Expr $expr): bool
             return false;
         }
 
-        /** @var ClassLike $classLike */
-        $classLike = $this->astResolver->resolveClassFromClassReflection($classReflection);
-        $propertyName = $this->nodeNameResolver->getName($expr->name);
-
-        if ($propertyName === null) {
-            return false;
-        }
-
-        // A. local property
-        $property = $classLike->getProperty($propertyName);
-        if ($property instanceof Property) {
-            $propertyProperty = $property->props[0];
-            return $propertyProperty->default instanceof Array_;
-        }
-
-        // B. another object property
         $phpPropertyReflection = $this->reflectionResolver->resolvePropertyReflectionFromPropertyFetch($expr);
         if ($phpPropertyReflection instanceof PhpPropertyReflection) {
             $reflectionProperty = $phpPropertyReflection->getNativeReflection();
             $betterReflection = $reflectionProperty->getBetterReflection();
             $defaultValueExpr = $betterReflection->getDefaultValueExpression();
 
-            if (! $defaultValueExpr instanceof Expr) {
-                return false;
-            }
-
-            $defaultValueType = $this->nodeTypeResolver->getType($defaultValueExpr);
-            return $defaultValueType->isArray()
-                ->yes();
+            return $defaultValueExpr instanceof Array_;
         }
 
         return false;