[CodeQuality] Remove SimplifyIfExactValueReturnValueRector, as overly…

… defensive + InlineSimplePropertyAnnotationRector as purely coding standard area (#3764)

build/target-repository/docs/rector_rules_overview.md

@@ -1,14 +1,14 @@
-# 420 Rules Overview
+# 418 Rules Overview
 
 <br>
 
 ## Categories
 
 - [Arguments](#arguments) (6)
 
-- [CodeQuality](#codequality) (78)
+- [CodeQuality](#codequality) (77)
 
-- [CodingStyle](#codingstyle) (39)
+- [CodingStyle](#codingstyle) (38)
 
 - [Compatibility](#compatibility) (1)
 
@@ -1404,23 +1404,6 @@ Changes if/else for same value as assign to ternary
 
 <br>
 
-### SimplifyIfExactValueReturnValueRector
-
-Changes compared to value and return of expr to direct return
-
-- class: [`Rector\CodeQuality\Rector\If_\SimplifyIfExactValueReturnValueRector`](../rules/CodeQuality/Rector/If_/SimplifyIfExactValueReturnValueRector.php)
-
-```diff
- $value = 'something';
--if ($value === 52) {
--    return 52;
--}
--
- return $value;
-```
-
-<br>
-
 ### SimplifyIfNotNullReturnRector
 
 Changes redundant null check to instant return
@@ -2143,51 +2126,6 @@ Refactor `func_get_args()` in to a variadic param
 
 <br>
 
-### InlineSimplePropertyAnnotationRector
-
-Inline simple `@var` annotations (or other annotations) when they are the only thing in the phpdoc
-
-:wrench: **configure it!**
-
-- class: [`Rector\CodingStyle\Rector\Property\InlineSimplePropertyAnnotationRector`](../rules/CodingStyle/Rector/Property/InlineSimplePropertyAnnotationRector.php)
-
-```php
-<?php
-
-declare(strict_types=1);
-
-use Rector\CodingStyle\Rector\Property\InlineSimplePropertyAnnotationRector;
-use Rector\Config\RectorConfig;
-
-return static function (RectorConfig $rectorConfig): void {
-    $rectorConfig->ruleWithConfiguration(InlineSimplePropertyAnnotationRector::class, [
-        'var',
-        'phpstan-var',
-    ]);
-};
-```
-
-↓
-
-```diff
- final class SomeClass
- {
--    /**
--     * @phpstan-var string
--     */
-+    /** @phpstan-var string */
-     private const TEXT = 'text';
-
--    /**
--     * @var DateTime[]
--     */
-+    /** @var DateTime[] */
-     private ?array $dateTimes;
- }
-```
-
-<br>
-
 ### MakeInheritedMethodVisibilitySameAsParentRector
 
 Make method visibility same as parent one
@@ -5398,11 +5336,13 @@ Replace `each()` assign outside loop
 
 ```diff
  $array = ['b' => 1, 'a' => 2];
+
 -$eachedArray = each($array);
 +$eachedArray[1] = current($array);
 +$eachedArray['value'] = current($array);
 +$eachedArray[0] = key($array);
 +$eachedArray['key'] = key($array);
++
 +next($array);
 ```
 

config/set/code-quality.php

@@ -62,7 +62,6 @@
 use Rector\CodeQuality\Rector\If_\ExplicitBoolCompareRector;
 use Rector\CodeQuality\Rector\If_\ShortenElseIfRector;
 use Rector\CodeQuality\Rector\If_\SimplifyIfElseToTernaryRector;
-use Rector\CodeQuality\Rector\If_\SimplifyIfExactValueReturnValueRector;
 use Rector\CodeQuality\Rector\If_\SimplifyIfNotNullReturnRector;
 use Rector\CodeQuality\Rector\If_\SimplifyIfNullableReturnRector;
 use Rector\CodeQuality\Rector\If_\SimplifyIfReturnBoolRector;
@@ -192,7 +191,6 @@
         InlineIsAInstanceOfRector::class,
         TernaryFalseExpressionToIfRector::class,
         InlineConstructorDefaultToPropertyRector::class,
-        SimplifyIfExactValueReturnValueRector::class,
         SimplifyUselessLastVariableAssignRector::class,
         ReturnTypeFromStrictScalarReturnExprRector::class,
         TernaryEmptyArrayArrayDimFetchToCoalesceRector::class,

packages/BetterPhpDocParser/PhpDocInfo/PhpDocInfo.php

@@ -330,11 +330,6 @@ public function isNewNode(): bool
         return $this->betterTokenIterator->count() === 0;
     }
 
-    public function makeSingleLined(): void
-    {
-        $this->isSingleLine = true;
-    }
-
     public function isSingleLine(): bool
     {
         return $this->isSingleLine;