Add failing test fixture for ClassPropertyAssignToConstructorPromotionRector #1100
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@zingimmick I cherry-picked your commit at PR #1101 |
TomasVotruba
pushed a commit
that referenced
this pull request
Oct 29, 2021
…ionRector (#1101) * Add failing test fixture for ClassPropertyAssignToConstructorPromotionRector * Closes #1100 * cs fix * Add PropertyAnalyzer * [ci-review] Rector Rectify * rectify * clean up * [ci-review] Rector Rectify * [ci-review] Rector Rectify * [ci-review] Rector Rectify Co-authored-by: zingimmick <zingimmick@outlook.com> Co-authored-by: GitHub Action <action@github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
ClassPropertyAssignToConstructorPromotionRectorskipped the callable attributes, but did not skip the union types contains the callable type.