Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Php80] Skip union callable on ClassPropertyAssignToConstructorPromotionRector #1101

Merged
merged 10 commits into from
Oct 29, 2021
Merged

[Php80] Skip union callable on ClassPropertyAssignToConstructorPromotionRector #1101

merged 10 commits into from
Oct 29, 2021

Conversation

samsonasik
Copy link
Member

Closes #1100

@samsonasik samsonasik mentioned this pull request Oct 29, 2021
Closed
@samsonasik
Copy link
Member Author

All checks have passed 🎉 @TomasVotruba it is ready for review.

TomasVotruba
TomasVotruba reviewed Oct 29, 2021
View reviewed changes
rules/Php80/Rector/Class_/ClassPropertyAssignToConstructorPromotionRector.php Outdated
}
}

return false;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think similar logic is in TypedProperty rule.
Could you extract it and reuse it?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will try.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

implemented, I added PropertyAnalyzer to check it 7b813b7

@samsonasik
Copy link
Member Author

All checks have passed 🎉 @TomasVotruba I think it is ready.

@TomasVotruba TomasVotruba merged commit 5ca93fd into main Oct 29, 2021
@TomasVotruba TomasVotruba deleted the patch-2 branch October 29, 2021 14:00
@TomasVotruba
Copy link
Member

Thank you 😊

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TomasVotruba TomasVotruba TomasVotruba approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
4 participants
@samsonasik @TomasVotruba @zingimmick @actions-user