Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[NodeTypeResolver] Avoid error Uncaught TypeError: PHPStan\Type\Constant\ConstantIntegerType::__construct(): Argument #1 ($value) must be of type int, string given #1210

Merged
merged 2 commits into from
Nov 11, 2021
Merged

[NodeTypeResolver] Avoid error Uncaught TypeError: PHPStan\Type\Constant\ConstantIntegerType::__construct(): Argument #1 ($value) must be of type int, string given #1210

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
465016d
[NodeTypeResolver] Avoid error Uncaught TypeError: PHPStan\Type\Const…
samsonasik Nov 10, 2021
41ac952
final touch: ensure cast to (string) for ConstantStringType
samsonasik Nov 10, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
6 changes: 3 additions & 3 deletions packages/NodeTypeResolver/NodeTypeResolver/ScalarTypeResolver.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,15 +32,15 @@ public function getNodeClasses(): array
public function resolve(Node $node): Type
{
if ($node instanceof DNumber) {
return new ConstantFloatType($node->value);
return new ConstantFloatType((float) $node->value);
}

if ($node instanceof String_) {
return new ConstantStringType($node->value);
return new ConstantStringType((string) $node->value);
}

if ($node instanceof LNumber) {
return new ConstantIntegerType($node->value);
return new ConstantIntegerType((int) $node->value);
}

if ($node instanceof MagicConst) {
Expand Down