Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[NodeTypeResolver] Avoid error Uncaught TypeError: PHPStan\Type\Constant\ConstantIntegerType::__construct(): Argument #1 ($value) must be of type int, string given #1210

Merged
merged 2 commits into from Nov 11, 2021
Merged

[NodeTypeResolver] Avoid error Uncaught TypeError: PHPStan\Type\Constant\ConstantIntegerType::__construct(): Argument #1 ($value) must be of type int, string given #1210

merged 2 commits into from Nov 11, 2021

Conversation

samsonasik
Copy link
Member

@samsonasik samsonasik commented Nov 10, 2021 •
edited

Ensure cast value on passed value to ConstantFloatType and ConstantIntegerType, and ConstantStringType to avoid error like the following:

PHP Fatal error:  Uncaught TypeError: PHPStan\Type\Constant\ConstantIntegerType::__construct(): Argument #1 ($value) must be of type int, string given, called in /Users/samsonasik/www/CodeIgniter4/vendor/rector/rector/packages/NodeTypeResolver/NodeTypeResolver/ScalarTypeResolver.php on line 41 and defined in phar:///Users/samsonasik/www/CodeIgniter4/vendor/rector/rector/vendor/phpstan/phpstan/phpstan.phar/src/Type/Constant/ConstantIntegerType.php:24
Stack trace:
#0 /Users/samsonasik/www/CodeIgniter4/vendor/rector/rector/packages/NodeTypeResolver/NodeTypeResolver/ScalarTypeResolver.php(41): PHPStan\Type\Constant\ConstantIntegerType->__construct('1_048_576')
#1 /Users/samsonasik/www/CodeIgniter4/vendor/rector/rector/packages/NodeTypeResolver/NodeTypeResolver.php(365): Rector\NodeTypeResolver\NodeTypeResolver\ScalarTypeResolver->resolve(Object(PhpParser\Node\Scalar\LNumber))
#2 /Users/samsonasik/www/CodeIgniter4/vendor/rector/rector/packages/NodeTypeResolver/NodeTypeResolver.php(186): Rector\NodeTypeResolver\NodeTypeResolver->resolveByNodeTypeResolvers(Object(PhpParser\Node\Scalar\LNumber))
#3 /Users/samsonasik/www/CodeIgniter4/vendor/rector/rector/src/Rector/AbstractRector.php(324): Rector\NodeTypeResolver\NodeTypeResolver->getType(Object(PhpParser\Node\Scalar\LNumber))
#4 /Users/samsonasik/www/CodeIgniter4/vendor/rector/rector/rules/Php71/Rector/BinaryOp/BinaryOpBetweenNumberAndStringRector.php(95): Rector\Core\Rector\AbstractRector->getType(Object(PhpParser\Node\Scalar\LNumber))
#5 /Users/samsonasik/www/CodeIgniter4/vendor/rector/rector/rules/Php71/Rector/BinaryOp/BinaryOpBetweenNumberAndStringRector.php(79): Rector\Php71\Rector\BinaryOp\BinaryOpBetweenNumberAndStringRector->isStringOrStaticNonNumbericString(Object(PhpParser\Node\Scalar\LNumber))
#6 /Users/samsonasik/www/CodeIgniter4/vendor/rector/rector/src/Rector/AbstractRector.php(249): Rector\Php71\Rector\BinaryOp\BinaryOpBetweenNumberAndStringRector->refactor(Object(PhpParser\Node\Expr\BinaryOp\Smaller))
#7 /Users/samsonasik/www/CodeIgniter4/vendor/rector/rector/vendor/nikic/php-parser/lib/PhpParser/NodeTraverser.php(113): Rector\Core\Rector\AbstractRector->enterNode(Object(PhpParser\Node\Expr\BinaryOp\Smaller))
#8 /Users/samsonasik/www/CodeIgniter4/vendor/rector/rector/vendor/nikic/php-parser/lib/PhpParser/NodeTraverser.php(196): PhpParser\NodeTraverser->traverseNode(Object(PhpParser\Node\Stmt\If_))
#9 /Users/samsonasik/www/CodeIgniter4/vendor/rector/rector/vendor/nikic/php-parser/lib/PhpParser/NodeTraverser.php(105): PhpParser\NodeTraverser->traverseArray(Array)
#10 /Users/samsonasik/www/CodeIgniter4/vendor/rector/rector/vendor/nikic/php-parser/lib/PhpParser/NodeTraverser.php(196): PhpParser\NodeTraverser->traverseNode(Object(PhpParser\Node\Stmt\ClassMethod))
#11 /Users/samsonasik/www/CodeIgniter4/vendor/rector/rector/vendor/nikic/php-parser/lib/PhpParser/NodeTraverser.php(105): PhpParser\NodeTraverser->traverseArray(Array)
#12 /Users/samsonasik/www/CodeIgniter4/vendor/rector/rector/vendor/nikic/php-parser/lib/PhpParser/NodeTraverser.php(196): PhpParser\NodeTraverser->traverseNode(Object(PhpParser\Node\Stmt\Class_))
#13 /Users/samsonasik/www/CodeIgniter4/vendor/rector/rector/vendor/nikic/php-parser/lib/PhpParser/NodeTraverser.php(105): PhpParser\NodeTraverser->traverseArray(Array)
#14 /Users/samsonasik/www/CodeIgniter4/vendor/rector/rector/vendor/nikic/php-parser/lib/PhpParser/NodeTraverser.php(196): PhpParser\NodeTraverser->traverseNode(Object(PhpParser\Node\Stmt\Namespace_))
#15 /Users/samsonasik/www/CodeIgniter4/vendor/rector/rector/vendor/nikic/php-parser/lib/PhpParser/NodeTraverser.php(85): PhpParser\NodeTraverser->traverseArray(Array)
#16 /Users/samsonasik/www/CodeIgniter4/vendor/rector/rector/src/PhpParser/NodeTraverser/RectorNodeTraverser.php(52): PhpParser\NodeTraverser->traverse(Array)
#17 /Users/samsonasik/www/CodeIgniter4/vendor/rector/rector/src/Application/FileProcessor.php(49): Rector\Core\PhpParser\NodeTraverser\RectorNodeTraverser->traverse(Array)
#18 /Users/samsonasik/www/CodeIgniter4/vendor/rector/rector/src/Application/FileProcessor/PhpFileProcessor.php(132): Rector\Core\Application\FileProcessor->refactor(Object(Rector\Core\ValueObject\Application\File))
#19 /Users/samsonasik/www/CodeIgniter4/vendor/rector/rector/src/Application/FileProcessor/PhpFileProcessor.php(144): Rector\Core\Application\FileProcessor\PhpFileProcessor->Rector\Core\Application\FileProcessor\{closure}(Object(Rector\Core\ValueObject\Application\File))
#20 /Users/samsonasik/www/CodeIgniter4/vendor/rector/rector/src/Application/FileProcessor/PhpFileProcessor.php(133): Rector\Core\Application\FileProcessor\PhpFileProcessor->tryCatchWrapper(Object(Rector\Core\ValueObject\Application\File), Object(Closure), Object(Rector\Core\Enum\ApplicationPhase))
#21 /Users/samsonasik/www/CodeIgniter4/vendor/rector/rector/src/Application/FileProcessor/PhpFileProcessor.php(91): Rector\Core\Application\FileProcessor\PhpFileProcessor->refactorNodesWithRectors(Object(Rector\Core\ValueObject\Application\File))
#22 /Users/samsonasik/www/CodeIgniter4/vendor/rector/rector/src/Application/ApplicationFileProcessor.php(76): Rector\Core\Application\FileProcessor\PhpFileProcessor->process(Object(Rector\Core\ValueObject\Application\File), Object(Rector\Core\ValueObject\Configuration))
#23 /Users/samsonasik/www/CodeIgniter4/vendor/rector/rector/src/Application/ApplicationFileProcessor.php(57): Rector\Core\Application\ApplicationFileProcessor->processFiles(Array, Object(Rector\Core\ValueObject\Configuration))
#24 /Users/samsonasik/www/CodeIgniter4/vendor/rector/rector/src/Console/Command/ProcessCommand.php(152): Rector\Core\Application\ApplicationFileProcessor->run(Array, Object(Rector\Core\ValueObject\Configuration))
#25 /Users/samsonasik/www/CodeIgniter4/vendor/rector/rector/vendor/symfony/console/Command/Command.php(274): Rector\Core\Console\Command\ProcessCommand->execute(Object(RectorPrefix20211109\Symfony\Component\Console\Input\ArgvInput), Object(RectorPrefix20211109\Symfony\Component\Console\Output\ConsoleOutput))
#26 /Users/samsonasik/www/CodeIgniter4/vendor/rector/rector/vendor/symfony/console/Application.php(870): RectorPrefix20211109\Symfony\Component\Console\Command\Command->run(Object(RectorPrefix20211109\Symfony\Component\Console\Input\ArgvInput), Object(RectorPrefix20211109\Symfony\Component\Console\Output\ConsoleOutput))
#27 /Users/samsonasik/www/CodeIgniter4/vendor/rector/rector/vendor/symfony/console/Application.php(266): RectorPrefix20211109\Symfony\Component\Console\Application->doRunCommand(Object(Rector\Core\Console\Command\ProcessCommand), Object(RectorPrefix20211109\Symfony\Component\Console\Input\ArgvInput), Object(RectorPrefix20211109\Symfony\Component\Console\Output\ConsoleOutput))
#28 /Users/samsonasik/www/CodeIgniter4/vendor/rector/rector/src/Console/ConsoleApplication.php(71): RectorPrefix20211109\Symfony\Component\Console\Application->doRun(Object(RectorPrefix20211109\Symfony\Component\Console\Input\ArgvInput), Object(RectorPrefix20211109\Symfony\Component\Console\Output\ConsoleOutput))
#29 /Users/samsonasik/www/CodeIgniter4/vendor/rector/rector/vendor/symfony/console/Application.php(162): Rector\Core\Console\ConsoleApplication->doRun(Object(RectorPrefix20211109\Symfony\Component\Console\Input\ArgvInput), Object(RectorPrefix20211109\Symfony\Component\Console\Output\ConsoleOutput))
#30 /Users/samsonasik/www/CodeIgniter4/vendor/rector/rector/bin/rector.php(63): RectorPrefix20211109\Symfony\Component\Console\Application->run()
#31 /Users/samsonasik/www/CodeIgniter4/vendor/rector/rector/bin/rector(5): require_once('/Users/samsonas...')
#32 {main}
  thrown in phar:///Users/samsonasik/www/CodeIgniter4/vendor/rector/rector/vendor/phpstan/phpstan/phpstan.phar/src/Type/Constant/ConstantIntegerType.php on line 24

Fatal error: Uncaught TypeError: PHPStan\Type\Constant\ConstantIntegerType::__construct(): Argument #1 ($value) must be of type int, string given, called in /Users/samsonasik/www/CodeIgniter4/vendor/rector/rector/packages/NodeTypeResolver/NodeTypeResolver/ScalarTypeResolver.php on line 41 and defined in phar:///Users/samsonasik/www/CodeIgniter4/vendor/rector/rector/vendor/phpstan/phpstan/phpstan.phar/src/Type/Constant/ConstantIntegerType.php:24
Stack trace:
#0 /Users/samsonasik/www/CodeIgniter4/vendor/rector/rector/packages/NodeTypeResolver/NodeTypeResolver/ScalarTypeResolver.php(41): PHPStan\Type\Constant\ConstantIntegerType->__construct('1_048_576')
#1 /Users/samsonasik/www/CodeIgniter4/vendor/rector/rector/packages/NodeTypeResolver/NodeTypeResolver.php(365): Rector\NodeTypeResolver\NodeTypeResolver\ScalarTypeResolver->resolve(Object(PhpParser\Node\Scalar\LNumber))
#2 /Users/samsonasik/www/CodeIgniter4/vendor/rector/rector/packages/NodeTypeResolver/NodeTypeResolver.php(186): Rector\NodeTypeResolver\NodeTypeResolver->resolveByNodeTypeResolvers(Object(PhpParser\Node\Scalar\LNumber))
#3 /Users/samsonasik/www/CodeIgniter4/vendor/rector/rector/src/Rector/AbstractRector.php(324): Rector\NodeTypeResolver\NodeTypeResolver->getType(Object(PhpParser\Node\Scalar\LNumber))
#4 /Users/samsonasik/www/CodeIgniter4/vendor/rector/rector/rules/Php71/Rector/BinaryOp/BinaryOpBetweenNumberAndStringRector.php(95): Rector\Core\Rector\AbstractRector->getType(Object(PhpParser\Node\Scalar\LNumber))
#5 /Users/samsonasik/www/CodeIgniter4/vendor/rector/rector/rules/Php71/Rector/BinaryOp/BinaryOpBetweenNumberAndStringRector.php(79): Rector\Php71\Rector\BinaryOp\BinaryOpBetweenNumberAndStringRector->isStringOrStaticNonNumbericString(Object(PhpParser\Node\Scalar\LNumber))
#6 /Users/samsonasik/www/CodeIgniter4/vendor/rector/rector/src/Rector/AbstractRector.php(249): Rector\Php71\Rector\BinaryOp\BinaryOpBetweenNumberAndStringRector->refactor(Object(PhpParser\Node\Expr\BinaryOp\Smaller))
#7 /Users/samsonasik/www/CodeIgniter4/vendor/rector/rector/vendor/nikic/php-parser/lib/PhpParser/NodeTraverser.php(113): Rector\Core\Rector\AbstractRector->enterNode(Object(PhpParser\Node\Expr\BinaryOp\Smaller))
#8 /Users/samsonasik/www/CodeIgniter4/vendor/rector/rector/vendor/nikic/php-parser/lib/PhpParser/NodeTraverser.php(196): PhpParser\NodeTraverser->traverseNode(Object(PhpParser\Node\Stmt\If_))
#9 /Users/samsonasik/www/CodeIgniter4/vendor/rector/rector/vendor/nikic/php-parser/lib/PhpParser/NodeTraverser.php(105): PhpParser\NodeTraverser->traverseArray(Array)
#10 /Users/samsonasik/www/CodeIgniter4/vendor/rector/rector/vendor/nikic/php-parser/lib/PhpParser/NodeTraverser.php(196): PhpParser\NodeTraverser->traverseNode(Object(PhpParser\Node\Stmt\ClassMethod))
#11 /Users/samsonasik/www/CodeIgniter4/vendor/rector/rector/vendor/nikic/php-parser/lib/PhpParser/NodeTraverser.php(105): PhpParser\NodeTraverser->traverseArray(Array)
#12 /Users/samsonasik/www/CodeIgniter4/vendor/rector/rector/vendor/nikic/php-parser/lib/PhpParser/NodeTraverser.php(196): PhpParser\NodeTraverser->traverseNode(Object(PhpParser\Node\Stmt\Class_))
#13 /Users/samsonasik/www/CodeIgniter4/vendor/rector/rector/vendor/nikic/php-parser/lib/PhpParser/NodeTraverser.php(105): PhpParser\NodeTraverser->traverseArray(Array)
#14 /Users/samsonasik/www/CodeIgniter4/vendor/rector/rector/vendor/nikic/php-parser/lib/PhpParser/NodeTraverser.php(196): PhpParser\NodeTraverser->traverseNode(Object(PhpParser\Node\Stmt\Namespace_))
#15 /Users/samsonasik/www/CodeIgniter4/vendor/rector/rector/vendor/nikic/php-parser/lib/PhpParser/NodeTraverser.php(85): PhpParser\NodeTraverser->traverseArray(Array)
#16 /Users/samsonasik/www/CodeIgniter4/vendor/rector/rector/src/PhpParser/NodeTraverser/RectorNodeTraverser.php(52): PhpParser\NodeTraverser->traverse(Array)
#17 /Users/samsonasik/www/CodeIgniter4/vendor/rector/rector/src/Application/FileProcessor.php(49): Rector\Core\PhpParser\NodeTraverser\RectorNodeTraverser->traverse(Array)
#18 /Users/samsonasik/www/CodeIgniter4/vendor/rector/rector/src/Application/FileProcessor/PhpFileProcessor.php(132): Rector\Core\Application\FileProcessor->refactor(Object(Rector\Core\ValueObject\Application\File))
#19 /Users/samsonasik/www/CodeIgniter4/vendor/rector/rector/src/Application/FileProcessor/PhpFileProcessor.php(144): Rector\Core\Application\FileProcessor\PhpFileProcessor->Rector\Core\Application\FileProcessor\{closure}(Object(Rector\Core\ValueObject\Application\File))
#20 /Users/samsonasik/www/CodeIgniter4/vendor/rector/rector/src/Application/FileProcessor/PhpFileProcessor.php(133): Rector\Core\Application\FileProcessor\PhpFileProcessor->tryCatchWrapper(Object(Rector\Core\ValueObject\Application\File), Object(Closure), Object(Rector\Core\Enum\ApplicationPhase))
#21 /Users/samsonasik/www/CodeIgniter4/vendor/rector/rector/src/Application/FileProcessor/PhpFileProcessor.php(91): Rector\Core\Application\FileProcessor\PhpFileProcessor->refactorNodesWithRectors(Object(Rector\Core\ValueObject\Application\File))
#22 /Users/samsonasik/www/CodeIgniter4/vendor/rector/rector/src/Application/ApplicationFileProcessor.php(76): Rector\Core\Application\FileProcessor\PhpFileProcessor->process(Object(Rector\Core\ValueObject\Application\File), Object(Rector\Core\ValueObject\Configuration))
#23 /Users/samsonasik/www/CodeIgniter4/vendor/rector/rector/src/Application/ApplicationFileProcessor.php(57): Rector\Core\Application\ApplicationFileProcessor->processFiles(Array, Object(Rector\Core\ValueObject\Configuration))
#24 /Users/samsonasik/www/CodeIgniter4/vendor/rector/rector/src/Console/Command/ProcessCommand.php(152): Rector\Core\Application\ApplicationFileProcessor->run(Array, Object(Rector\Core\ValueObject\Configuration))
#25 /Users/samsonasik/www/CodeIgniter4/vendor/rector/rector/vendor/symfony/console/Command/Command.php(274): Rector\Core\Console\Command\ProcessCommand->execute(Object(RectorPrefix20211109\Symfony\Component\Console\Input\ArgvInput), Object(RectorPrefix20211109\Symfony\Component\Console\Output\ConsoleOutput))
#26 /Users/samsonasik/www/CodeIgniter4/vendor/rector/rector/vendor/symfony/console/Application.php(870): RectorPrefix20211109\Symfony\Component\Console\Command\Command->run(Object(RectorPrefix20211109\Symfony\Component\Console\Input\ArgvInput), Object(RectorPrefix20211109\Symfony\Component\Console\Output\ConsoleOutput))
#27 /Users/samsonasik/www/CodeIgniter4/vendor/rector/rector/vendor/symfony/console/Application.php(266): RectorPrefix20211109\Symfony\Component\Console\Application->doRunCommand(Object(Rector\Core\Console\Command\ProcessCommand), Object(RectorPrefix20211109\Symfony\Component\Console\Input\ArgvInput), Object(RectorPrefix20211109\Symfony\Component\Console\Output\ConsoleOutput))
#28 /Users/samsonasik/www/CodeIgniter4/vendor/rector/rector/src/Console/ConsoleApplication.php(71): RectorPrefix20211109\Symfony\Component\Console\Application->doRun(Object(RectorPrefix20211109\Symfony\Component\Console\Input\ArgvInput), Object(RectorPrefix20211109\Symfony\Component\Console\Output\ConsoleOutput))
#29 /Users/samsonasik/www/CodeIgniter4/vendor/rector/rector/vendor/symfony/console/Application.php(162): Rector\Core\Console\ConsoleApplication->doRun(Object(RectorPrefix20211109\Symfony\Component\Console\Input\ArgvInput), Object(RectorPrefix20211109\Symfony\Component\Console\Output\ConsoleOutput))
#30 /Users/samsonasik/www/CodeIgniter4/vendor/rector/rector/bin/rector.php(63): RectorPrefix20211109\Symfony\Component\Console\Application->run()
#31 /Users/samsonasik/www/CodeIgniter4/vendor/rector/rector/bin/rector(5): require_once('/Users/samsonas...')
#32 {main}
  thrown in phar:///Users/samsonasik/www/CodeIgniter4/vendor/rector/rector/vendor/phpstan/phpstan/phpstan.phar/src/Type/Constant/ConstantIntegerType.php on line 24

I can't reproduce via unit test but casting seems fix it.

@samsonasik
[NodeTypeResolver] Avoid error Uncaught TypeError: PHPStan\Type\Const…
465016d 
…ant\ConstantIntegerType::__construct(): Argument #1 ($value) must be of type int, string given
@samsonasik
Copy link
Member Author

All checks have passed 🎉 @TomasVotruba I think it is ready.

I can't reproduce it via failing fixture, it possibly due to collection of rules applied in single file, but this change seems fix it.

@TomasVotruba
Copy link
Member

Makes sense, the php-parser can sometimes produce string on numbers.

@TomasVotruba TomasVotruba merged commit 2ed0430 into main Nov 11, 2021
@TomasVotruba TomasVotruba deleted the avoid-error-scalar-type-resolver branch November 11, 2021 00:11
@staabm
Copy link
Contributor

staabm commented Nov 11, 2021

Could you re-use https://github.com/phpstan/phpstan-src/blob/master/src/Type/ConstantTypeHelper.php in this class?

@TomasVotruba
Copy link
Member

It seems that does not handle string type in number.

@samsonasik samsonasik mentioned this pull request Dec 14, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@samsonasik @TomasVotruba @staabm