[DeadCode] Do not remove parameter on RemoveUnusedPrivatePropertyRector on constructor only usage in the middle of parameter

[samsonasik]

Given the following code:

class SkipConstructorOnlyInMiddleParameterUsed
{
    /**
     * @var int
     */
    private $contentFinder;

    public function __construct(int $contentFinder, \stdClass $stdClass)
    {
        $this->contentFinder = $contentFinder;
        $this->init($stdClass);
    }

    private function init(\stdClass $stdClass)
    {
        var_dump($stdClass);
    }
}

It produce:

-    public function __construct(int $contentFinder, \stdClass $stdClass)
+    public function __construct(\stdClass $stdClass)
     {
-        $this->contentFinder = $contentFinder;
         $this->init($stdClass);

which can make the caller of the class error. It needs to be skipped.

[TomasVotruba]

The constructor might be BC break in case of scalar values. But the removal of property assign and property seems legit.

[samsonasik]

This is only effect if the removed parameter not in the last used parameter, as the caller which call:

(new SkipConstructorOnlyInMiddleParameterUsed(1, new stdClass));

will got error:

Uncaught TypeError: SkipConstructorOnlyInMiddleParameterUsed::__construct(): Argument #1 ($stdClass) must be of type stdClass, int given

ref https://3v4l.org/A6PvC

[samsonasik]

Ok, it seems the removal should be only for :

• property
• assign

but keep the constructor parameter.

[samsonasik]

@TomasVotruba I updated failing fixture to only remove property and assign ,but keep the constructor parameter as it happen not in last parameter

1f72f8e

[samsonasik]

Fixed 🎉

[samsonasik]

All checks have passed 🎉 @TomasVotruba it is ready for review.

[TomasVotruba]

Btw, what has changed here? The file looks identical. EOLs?

[samsonasik]

that's seems spacing and eol

[TomasVotruba]

Thank you 👏