[DowngradePhp72] Handle in assign on DowngradePregUnmatchedAsNullConstantRector #1872
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samsonasik
force-pushed
the
handle-in-assign-on-downgrade-preg-unmatched-as-null
branch
from
14d1e99
to
3ffb3b9
Compare
|
Fixed 🎉 let's give it a try ;) |
samsonasik
deleted the
handle-in-assign-on-downgrade-preg-unmatched-as-null
branch
|
@TomasVotruba it works 🎉
|
|
It seems cause error when used : bin/rector -vvv
In PcreException.php line 26:
[RectorPrefix20220226\Composer\Pcre\PcreException]
preg_match(): failed executing "/^\s*\[(?:PATH|HOST)\s*=/mi": No error
Exception trace:
at /Users/samsonasik/www/GithubModules/ErrorHeroModule/vendor/rector/rector/vendor/composer/pcre/src/PcreException.php:26
RectorPrefix20220226\Composer\Pcre\PcreException::fromFunction() at /Users/samsonasik/www/GithubModules/ErrorHeroModule/vendor/rector/rector/vendor/composer/pcre/src/Preg.php:64
RectorPrefix20220226\Composer\Pcre\Preg::matchWithOffsets() at /Users/samsonasik/www/GithubModules/ErrorHeroModule/vendor/rector/rector/vendor/composer/pcre/src/Preg.php:251
RectorPrefix20220226\Composer\Pcre\Preg::isMatchWithOffsets() at /Users/samsonasik/www/GithubModules/ErrorHeroModule/vendor/rector/rector/vendor/composer/xdebug-handler/src/XdebugHandler.php:313
RectorPrefix20220226\Composer\XdebugHandler\XdebugHandler->writeTmpIni() at /Users/samsonasik/www/GithubModules/ErrorHeroModule/vendor/rector/rector/vendor/composer/xdebug-handler/src/XdebugHandler.php:278
RectorPrefix20220226\Composer\XdebugHandler\XdebugHandler->prepareRestart() at /Users/samsonasik/www/GithubModules/ErrorHeroModule/vendor/rector/rector/vendor/composer/xdebug-handler/src/XdebugHandler.php:119
RectorPrefix20220226\Composer\XdebugHandler\XdebugHandler->check() at /Users/samsonasik/www/GithubModules/ErrorHeroModule/vendor/rector/rector/src/Console/ConsoleApplication.php:45
Rector\Core\Console\ConsoleApplication->doRun() at /Users/samsonasik/www/GithubModules/ErrorHeroModule/vendor/rector/rector/vendor/symfony/console/Application.php:187
RectorPrefix20220226\Symfony\Component\Console\Application->run() at /Users/samsonasik/www/GithubModules/ErrorHeroModule/vendor/rector/rector/bin/rector.php:57
require_once() at /Users/samsonasik/www/GithubModules/ErrorHeroModule/vendor/rector/rector/bin/rector:5
include() at /Users/samsonasik/www/GithubModules/ErrorHeroModule/bin/rector:117I will look into it, it seems |
|
Fixed at #1873 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current rector build scoped got the following error due to update to
composer/pcre 3.0.0:bin/rector process vendor/composer/pcre/src/Preg.php -c build/config/config-downgrade.php --dry-run -vvv --clear-cache [parsing] vendor/composer/pcre/src/Preg.php [refactoring] vendor/composer/pcre/src/Preg.php [applying] Rector\Removing\Rector\Class_\RemoveInterfacesRector [applying] Rector\DowngradePhp80\Rector\Class_\DowngradeAttributeToAnnotationRector [applying] Rector\DowngradePhp80\Rector\Class_\DowngradePropertyPromotionRector [applying] Rector\DowngradePhp81\Rector\ClassConst\DowngradeFinalizePublicClassConstantRector [applying] Rector\DowngradePhp72\Rector\FuncCall\DowngradePregUnmatchedAsNullConstantRector [applying] Rector\DowngradePhp73\Rector\String_\DowngradeFlexibleHeredocSyntaxRector [applying] Rector\DowngradePhp81\Rector\FunctionLike\DowngradeNeverTypeDeclarationRector [applying] Rector\DowngradePhp81\Rector\FunctionLike\DowngradePureIntersectionTypeRector [applying] Rector\DowngradePhp81\Rector\FunctionLike\DowngradeNewInInitializerRector [applying] Rector\DowngradePhp80\Rector\FunctionLike\DowngradeUnionTypeDeclarationRector [applying] Rector\DowngradePhp80\Rector\FunctionLike\DowngradeMixedTypeDeclarationRector [applying] Rector\DowngradePhp80\Rector\ClassMethod\DowngradeStaticTypeDeclarationRector [applying] Rector\DowngradePhp80\Rector\ClassMethod\DowngradeAbstractPrivateMethodInTraitRector [applying] Rector\DowngradePhp80\Rector\ClassMethod\DowngradeTrailingCommasInParamUseRector [applying] Rector\DowngradePhp80\Rector\ClassMethod\DowngradeRecursiveDirectoryIteratorHasChildrenRector [applying] Rector\DowngradePhp80\Rector\ClassMethod\DowngradeStringReturnTypeOnToStringRector [applying] Rector\DowngradePhp74\Rector\ClassMethod\DowngradeCovariantReturnTypeRector [applying] Rector\DowngradePhp74\Rector\ClassMethod\DowngradeContravariantArgumentTypeRector [applying] Rector\DowngradePhp72\Rector\FunctionLike\DowngradeObjectTypeDeclarationRector [applying] Rector\DowngradePhp72\Rector\ClassMethod\DowngradeParameterTypeWideningRector [applying] Rector\DowngradePhp81\Rector\Property\DowngradeReadonlyPropertyRector [applying] Rector\DowngradePhp73\Rector\ConstFetch\DowngradePhp73JsonConstRector [applying] Rector\DowngradePhp72\Rector\ConstFetch\DowngradePhp72JsonConstRector [applying] Rector\DowngradePhp74\Rector\LNumber\DowngradeNumericLiteralSeparatorRector [applying] Rector\DowngradePhp80\Rector\MethodCall\DowngradeNamedArgumentRector [applying] Rector\DowngradePhp80\Rector\New_\DowngradeArbitraryExpressionsSupportRector [applying] Rector\DowngradePhp73\Rector\FuncCall\DowngradeTrailingCommasInFunctionCallsRector [applying] Rector\DowngradePhp80\Rector\Expression\DowngradeMatchToSwitchRector [applying] Rector\DowngradePhp80\Rector\Expression\DowngradeThrowExprRector [applying] Rector\DowngradePhp81\Rector\FuncCall\DowngradeFirstClassCallableSyntaxRector [applying] Rector\DowngradePhp80\Rector\FuncCall\DowngradeStrContainsRector [applying] Rector\DowngradePhp80\Rector\FuncCall\DowngradeStrStartsWithRector [applying] Rector\DowngradePhp80\Rector\FuncCall\DowngradeStrEndsWithRector [applying] Rector\DowngradePhp80\Rector\FuncCall\DowngradeArrayFilterNullableCallbackRector [applying] Rector\DowngradePhp80\Rector\FuncCall\DowngradeNumberFormatNoFourthArgRector [applying] Rector\DowngradePhp74\Rector\FuncCall\DowngradeStripTagsCallWithArrayRector [applying] Rector\DowngradePhp74\Rector\FuncCall\DowngradeArrayMergeCallWithoutArgumentsRector [applying] Rector\DowngradePhp73\Rector\FuncCall\DowngradeArrayKeyFirstLastRector [applying] Rector\DowngradePhp73\Rector\FuncCall\SetCookieOptionsArrayToArgumentsRector [applying] Rector\DowngradePhp73\Rector\FuncCall\DowngradeIsCountableRector In DowngradePregUnmatchedAsNullConstantRector.php line 202: [Rector\Core\Exception\NotImplementedYetException] Exception trace: at /Users/samsonasik/www/rector-src/rules/DowngradePhp72/Rector/FuncCall/DowngradePregUnmatchedAsNullConstantRector.php:202 Rector\DowngradePhp72\Rector\FuncCall\DowngradePregUnmatchedAsNullConstantRector->processReplace() at /Users/samsonasik/www/rector-src/rules/DowngradePhp72/Rector/FuncCall/DowngradePregUnmatchedAsNullConstantRector.php:177 Rector\DowngradePhp72\Rector\FuncCall\DowngradePregUnmatchedAsNullConstantRector->handleEmptyStringToNullMatch() at /Users/samsonasik/www/rector-src/rules/DowngradePhp72/Rector/FuncCall/DowngradePregUnmatchedAsNullConstantRector.php:84 Rector\DowngradePhp72\Rector\FuncCall\DowngradePregUnmatchedAsNullConstantRector->refactor() at /Users/samsonasik/www/rector-src/src/Rector/AbstractRector.php:233 Rector\Core\Rector\AbstractRector->enterNode() at /Users/samsonasik/www/rector-src/vendor/nikic/php-parser/lib/PhpParser/NodeTraverser.php:123 PhpParser\NodeTraverser->traverseNode() at /Users/samsonasik/www/rector-src/vendor/nikic/php-parser/lib/PhpParser/NodeTraverser.php:146 PhpParser\NodeTraverser->traverseNode() at /Users/samsonasik/www/rector-src/vendor/nikic/php-parser/lib/PhpParser/NodeTraverser.php:223 PhpParser\NodeTraverser->traverseArray() at /Users/samsonasik/www/rector-src/vendor/nikic/php-parser/lib/PhpParser/NodeTraverser.php:114 PhpParser\NodeTraverser->traverseNode() at /Users/samsonasik/www/rector-src/vendor/nikic/php-parser/lib/PhpParser/NodeTraverser.php:223 PhpParser\NodeTraverser->traverseArray() at /Users/samsonasik/www/rector-src/vendor/nikic/php-parser/lib/PhpParser/NodeTraverser.php:114 PhpParser\NodeTraverser->traverseNode() at /Users/samsonasik/www/rector-src/vendor/nikic/php-parser/lib/PhpParser/NodeTraverser.php:223 PhpParser\NodeTraverser->traverseArray() at /Users/samsonasik/www/rector-src/vendor/nikic/php-parser/lib/PhpParser/NodeTraverser.php:114 PhpParser\NodeTraverser->traverseNode() at /Users/samsonasik/www/rector-src/vendor/nikic/php-parser/lib/PhpParser/NodeTraverser.php:223 PhpParser\NodeTraverser->traverseArray() at /Users/samsonasik/www/rector-src/vendor/nikic/php-parser/lib/PhpParser/NodeTraverser.php:91 PhpParser\NodeTraverser->traverse() at /Users/samsonasik/www/rector-src/src/PhpParser/NodeTraverser/RectorNodeTraverser.php:44 Rector\Core\PhpParser\NodeTraverser\RectorNodeTraverser->traverse() at /Users/samsonasik/www/rector-src/src/Application/FileProcessor.php:40 Rector\Core\Application\FileProcessor->refactor() at /Users/samsonasik/www/rector-src/src/Application/FileProcessor/PhpFileProcessor.php:109 Rector\Core\Application\FileProcessor\PhpFileProcessor->refactorNodesWithRectors() at /Users/samsonasik/www/rector-src/src/Application/FileProcessor/PhpFileProcessor.php:64 Rector\Core\Application\FileProcessor\PhpFileProcessor->process() at /Users/samsonasik/www/rector-src/src/Application/ApplicationFileProcessor.php:132 Rector\Core\Application\ApplicationFileProcessor->processFiles() at /Users/samsonasik/www/rector-src/src/Application/ApplicationFileProcessor.php:91 Rector\Core\Application\ApplicationFileProcessor->run() at /Users/samsonasik/www/rector-src/src/Console/Command/ProcessCommand.php:96 Rector\Core\Console\Command\ProcessCommand->execute() at /Users/samsonasik/www/rector-src/vendor/symfony/console/Command/Command.php:291 Symfony\Component\Console\Command\Command->run() at /Users/samsonasik/www/rector-src/vendor/symfony/console/Application.php:989 Symfony\Component\Console\Application->doRunCommand() at /Users/samsonasik/www/rector-src/vendor/symfony/console/Application.php:299 Symfony\Component\Console\Application->doRun() at /Users/samsonasik/www/rector-src/src/Console/ConsoleApplication.php:79 Rector\Core\Console\ConsoleApplication->doRun() at /Users/samsonasik/www/rector-src/vendor/symfony/console/Application.php:171 Symfony\Component\Console\Application->run() at /Users/samsonasik/www/rector-src/bin/rector.php:72 require_once() at /Users/samsonasik/www/rector-src/bin/rector:4 process [-n|--dry-run] [-a|--autoload-file AUTOLOAD-FILE] [--no-progress-bar] [--no-diffs] [--output-format OUTPUT-FORMAT] [--memory-limit MEMORY-LIMIT] [--clear-cache] [--port PORT] [--identifier IDENTIFIER] [--] [<source>...]This PR try to fix it.
Fixes rectorphp/rector#7025