[Util] Early strtolower() on StaticRectorStrings::isInArrayInsensitive()

[samsonasik]

instead of run strtolower inside foreach, make variable and early assign for strtolower.

[samsonasik]

@TomasVotruba we may need a new rule for this, eg: MoveFunctionVariableBeforeLoopRector, this can be happen on another use case:

function findFirstLengthEquals($data, $value)
{
+     $strlenValue = strlen($value);
      foreach ($data as $d) {
-             if (strlen($d) === strlen($value)) {
+             if (strlen($d) === $strlenValue) {
                  return $d;
             }
      } 
      return null;
}

what do you think?

[TomasVotruba]

I think this can be handled maually, the complexity for Rector seems to high for such a specific case.

[staabm]

I think this can be handled maually, the complexity for Rector seems to high for such a specific case.

If a rector-rule could do this for all pure-functions (instead of a specific rector for e.g. strlen() only), it could be worthwhile.