[Core] Apply Scope refresh for Namespace_ and FileWithoutNamespace

[samsonasik]

No description provided.

[samsonasik]

implemented 🎉 with check:

• has no Scope
• Node is Namespace_ or FileWithoutNamespace

then fallback to use Scope from ScopeFactory:

$mutatingScope = $this->scopeFactory->createFromFile($smartFileInfo);

[samsonasik]

All checks have passed 🎉 @TomasVotruba it is ready for review.

[TomasVotruba]

I wonder, there should be also some test to cover this fix. To make sure it will not be regressed in the future.

[samsonasik]

The test already exists, when only unregister Namespace_ and FileWithoutNamespace, it will got error:

There were 4 errors:
1) Rector\Tests\PSR4\Rector\FileWithoutNamespace\NormalizeNamespaceByPSR4ComposerAutoloadRector\NormalizeNamespaceByPSR4ComposerAutoloadRectorTest::test with data set #3 (Symplify\SmartFileSystem\SmartFileInfo Object (...))
Rector\Core\Exception\ShouldNotHappenException: Node "PhpParser\Node\Stmt\Namespace_" with parent of "" is missing scope required for scope refresh.

https://github.com/rectorphp/rector-src/runs/7058239145?check_suite_focus=true#step:5:87

On first commit e5941ba

[TomasVotruba]

I see it now, thank you 👍