[DX] Inline symplify/astral to use only active classes #2851
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TomasVotruba
changed the title
TomasVotruba
force-pushed
the
tv-less-astral
branch
from
f95240a
to
001b0ca
Compare
TomasVotruba
force-pushed
the
tv-less-astral
branch
from
97b3d4b
to
7d9d735
Compare
TomasVotruba
force-pushed
the
tv-less-astral
branch
from
811cef9
to
8402e9b
Compare
TomasVotruba
force-pushed
the
tv-less-astral
branch
from
47555e5
to
af98234
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The https://github.com/symplify/astral package was originally extracted from here to make easier re-use of the same concepts. But in the end, the cost of maintaining external dependency along with whole Symplify release just to add single fix/feature to Rector was too high.
This PR inlines only the classes that we use and make the best of those 😉 👍