[Skipper] Handle provide direct relative path in Skipper

[samsonasik]

Fixes rectorphp/rector#7467

Step to reproduce:

cd e2e/skip-direct-file-path 
composer install
php ../e2eTestRunnerPath.php src/Test.php 

[samsonasik]

Fixed 🎉 /cc @AlexOstrovsky

[samsonasik]

All checks have passed 🎉 @TomasVotruba it is ready for review.

[samsonasik]

I added another failing test case for skip with path list only 187d685 , not by rector rule -> path.

with config:

<?php

declare(strict_types=1);

use Rector\Config\RectorConfig;
use Rector\Naming\Rector\ClassMethod\RenameParamToMatchTypeRector;
use Rector\Set\ValueObject\SetList;

return static function (RectorConfig $rectorConfig): void {
    $rectorConfig->paths([__DIR__ . '/src']);

    $rectorConfig->skip([
        __DIR__ . '/src',
    ]);

    $rectorConfig->sets([SetList::NAMING]);
};

then use command:

php ../e2eTestRunnerPath.php -c rector_skip_path_list.php src/Test.php

[samsonasik]

Fixed 🎉

[samsonasik]

To run test locally:

cd e2e/skip-direct-file-path
composer install --ansi

# run e2e test direct path
php ../e2eTestRunnerPath.php src/Test.php

# run e2e test only directory
php ../e2eTestRunnerPath.php src

# run e2e test no path, look by rector.php
php ../e2eTestRunnerPath.php

# run e2e test with config use path lists
php ../e2eTestRunnerPath.php -c rector_skip_path_list.php src/Test.php

[samsonasik]

All checks have passed 🎉 🎉 🎉 @TomasVotruba I think it is ready.

[TomasVotruba]

The e2e is too heavy test here. This should be unit tested only.

[samsonasik]

@TomasVotruba the test is for relative path file location to check itself provided by command:

vendor/bin/rector process src/Test.php

that only happen when direct relative path provided in command itself.

which config can be:

    $rectorConfig->skip([
        RenameParamToMatchTypeRector::class => [__DIR__ . '/src'],
    ]);

Or

    $rectorConfig->skip([
         __DIR__ . '/src',
    ]);

so I think the way to test it is by using e2e test, Do we have example for unit test with path in command test?

[TomasVotruba]

Do we have example for unit test with path in command test?

This is not neccesary. The path is only argument, that will be passed in configuration.

What is the input value that goes to a skipper component in case of running Rector?

vendor/bin/rector process src/Test.php?

That's what should be tested only in Skipper unit test.

[samsonasik]

@TomasVotruba Ok, moved to unit test with relative path provided in test provider eca1683 👍

[samsonasik]

All checks have passed 🎉 @TomasVotruba I think it is ready now.

[TomasVotruba]

Thank you 👍