Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AutoImport] Allow auto import to use existing alias in use statement #2937

Merged
merged 10 commits into from
Sep 18, 2022

Conversation

samsonasik
Copy link
Member

Currently, auto import on given the following code is skipped:

use stdClass as SomeObject;

final class AutoImportInAlias extends \stdClass
{
}

ref https://getrector.org/demo/cf4bc31b-d150-4050-9ba9-a3a3845aced2

This PR is make if there is existing alias in use statement, use as is.

@samsonasik samsonasik force-pushed the allow-auto-import-alias branch 2 times, most recently from 91edcfb to b1e9f2e Compare September 18, 2022 15:25
@samsonasik
Copy link
Member Author

All checks have passed 🎉 @TomasVotruba it is ready for review.

@TomasVotruba TomasVotruba merged commit bad6a29 into main Sep 18, 2022
@TomasVotruba TomasVotruba deleted the allow-auto-import-alias branch September 18, 2022 17:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants