Revert all is* changes #3584
Merged
Revert all is* changes #3584
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 073f2d6.
|
It seems working ok now, let's merge 👍 |
|
Thanks 👍 |
|
Thank you @samsonasik and again sorry for the extra work! |
|
I already start with most safe type: void #3586 You can see the rector and cs run on the workflow https://github.com/rectorphp/rector-src/blob/main/.github/workflows/rector.yaml#L12 You can run: |
|
@samsonasik perfect! thank you! I'll make sure to open PRs for the others running all those checks! |
samsonasik
added a commit
that referenced
this pull request
May 8, 2023
* Revert fix cs (#3579) This reverts commit e66317a. * Revert Use isInteger() (#3571) This reverts commit 59cdfc8. * Revert Use isBoolean() (#3570) This reverts commit 437cc5a. * Revert Use isVoid() (#3574) This reverts commit 7611dcb. * Revert Use isString() (#3573) This reverts commit aa73118. * Revert Use isFloat() (#3572) This reverts commit 46301c1. * Revert Improve ArraySpreadInsteadOfArrayMergeRector (#3568) This reverts commit 073f2d6.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@TomasVotruba @yguedidi let's try revert all is* changes.