Make ConsecutiveNullCompareReturnsToNullCoalesceQueueRector use of StmtsAwareInterface

[TomasVotruba]

No description provided.

[TomasVotruba]

@samsonasik Hi Abdul, I'm trying to remove all the next/previous node and replace with direct StmtsAwareInterface. That will help with improving memory load of the node tree as in PHPStan.

Could you help out? Take any rule and let's resolve them one by one :)

[samsonasik]

Using StmtsAwareInterface doesn't make memory lower, if we still need re-connect after refactor, see:

rector-src/src/Rector/AbstractRector.php

Line 441 in 11b278c

$this->nodeConnectingTraverser->traverse($nodes);

If we need to test it out, we can remove the above call, and run tests:

vendor/bin/phpunit tests/Issues

and many errors will happen.

There is a condition which next/prev is needed, eg: on next of Expr, eg:

rector-src/src/PhpParser/Parser/InlineCodeParser.php

Line 150 in 11b278c

$node = $concat->getAttribute(AttributeKey::NEXT_NODE);

Reduce is possible, but removing is possibly huge BC break on end user.

[TomasVotruba]

At the moment yes, we need traversing. The goal is to remove dependency on any connected nodes whatsoever.

It might take time, but it's worth it as we will release lot of memory connections.