Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DX] Show progress bar 100% on RectorConsoleOutputFormatter::report() #4516

Merged
merged 2 commits into from
Jul 14, 2023

Conversation

samsonasik
Copy link
Member

@samsonasik
Copy link
Member Author

All checks have passed 🎉 @TomasVotruba I am merging it ;)

@samsonasik samsonasik merged commit d41685d into main Jul 14, 2023
43 checks passed
@samsonasik samsonasik deleted the show-progress branch July 14, 2023 19:47
@samsonasik
Copy link
Member Author

@TomasVotruba it works 🎉 ;)

@samsonasik
Copy link
Member Author

Tested in CodeIgniter4 project:

Before only show 99%

➜  CodeIgniter4 git:(develop) ✗ time vendor/bin/rector process --clear-cache
 783/790 [▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓░]  99%

                                                                                
 [OK] Rector is done!                                                           
                                                                                

vendor/bin/rector process --clear-cache  292,09s user 4,52s system 764% cpu 38,809 total

After: show 100%

➜  CodeIgniter4 git:(develop) ✗ time vendor/bin/rector process --clear-cache
 790/790 [▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓] 100%

                                                                                
 [OK] Rector is done!                                                           
                                                                                

vendor/bin/rector process --clear-cache  284,86s user 4,23s system 760% cpu 38,004 total

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant