Make use of toPhpDocNode() - take #8 #4570
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TomasVotruba
changed the title
TomasVotruba
force-pushed
the
tv-make-use-of-phpstan-phpdoctype-8
branch
2 times, most recently
from
a19b1b1
to
00f99f9
Compare
TomasVotruba
force-pushed
the
tv-make-use-of-phpstan-phpdoctype-8
branch
from
37b6da0
to
17b0924
Compare
samsonasik
reviewed
Jul 23, 2023
| Assert::allIsInstanceOf($callableTypeParameterNodes, CallableTypeParameterNode::class); | ||
|
|
||
| return new SpacingAwareCallableTypeNode($identifierTypeNode, $callableTypeParameterNodes, $returnDocTypeNode); | ||
| return $type->toPhpDocNode(); |
There was a problem hiding this comment.
@TomasVotruba this may need fqcn with add \ if Closure is not in use statement, as mapToPhpParserNode() returns FullyQualified object.
this fqcn closure is valid doc https://phpstan.org/r/f2a7c394-a8b0-45ec-aebb-f0ad7dabe95a
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref rectorphp/rector#7959