[PHPStanStaticTypeMapper] FQCN for Closure type mapper

[samsonasik]

Ref #4570 (review)

[samsonasik]

All checks have passed 🎉 @TomasVotruba I think it is ready.

[samsonasik]

@TomasVotruba the issue with this is, currently, $rectorConfig->importNames() doesn't detect it to be imported to use statement, so NameImportingPhpDocNodeVisitor need to be refactored to allow detect it.

rector-src/packages/NodeTypeResolver/PhpDocNodeVisitor/NameImportingPhpDocNodeVisitor.php

Lines 59 to 63 in c12703d

	if (! $node instanceof IdentifierTypeNode) {
	return null;
	}
	$staticType = $this->identifierTypeMapper->mapIdentifierTypeNode($node, $this->currentPhpParserNode);

[samsonasik]

It seems NameImportingPhpDocNodeVisitor need to support PHPStan\PhpDocParser\Ast\Type\CallableTypeNode

[samsonasik]

I added auto import failing test case

[samsonasik]

short classes seems excluded by default, so it won't be applied even tweaked

rector-src/packages/NodeTypeResolver/PhpDocNodeVisitor/NameImportingPhpDocNodeVisitor.php

Lines 69 to 72 in 079cd51

	// Importing root namespace classes (like \DateTime) is optional
	if ($this->shouldSkipShortClassName($staticType)) {
	return null;
	}

I reverted auto import test.

The FQCN-ize is happen on printing, so it should be ok.

[samsonasik]

I added test to skip reprint for existing closure nullable skip already nullable closure var so should be fine

[samsonasik]

All checks have passed 🎉 @TomasVotruba let's merge it to have faster feedback to test ;)