[DX] deprecated build shipped debug fuctions, allow using custom debug package instead; add local d() and dd() functions #4759
Conversation
TomasVotruba
changed the title
TomasVotruba
force-pushed
the
tv-tracy-less
branch
from
1d8f784
to
455f7b6
Compare
| "tomasvotruba/type-coverage": "^0.2", | ||
| "tomasvotruba/unused-public": "^0.2" | ||
| "tomasvotruba/unused-public": "^0.2", | ||
| "tracy/tracy": "^2.9" |
There was a problem hiding this comment.
all rector extensions will require-dev tracy/tracy then, or require back rector-debugging
There was a problem hiding this comment.
I'm aware 👍 Let's add tracy/tracy if needed actually :)
There was a problem hiding this comment.
I think require-dev rector/rector-debugging is the fastest way to avoid unnecesary add new functions.
There was a problem hiding this comment.
i want to keep dependency amount as low as possible. It's a common practice to let devs use the debugging packages/tools they need, when they need it.
Lets keep it as it is now = no changes in packages
There was a problem hiding this comment.
What I mean is add back rector/rector-debugging to require-dev into every rector-* extensions, and add here in require-dev as well.
require-dev is not shipped in rector build, but that will speed up dev
There was a problem hiding this comment.
The issue without debug tool in rector extensions, eg: rector-phpunit is, that it will cause contributors hard to debug the node, even us, that's why if it removed, we need to add back rector/rector-debugging to require-dev in every packages:
- rector-src
- rector-phpunit
- rector-symfony
- rector-doctrine
- rector-downgrade-php
require-dev is not shipped in rector build, but that will speed up dev
There was a problem hiding this comment.
For note, https://github.com/rectorphp/rector-debugging is archived, if that will be used, that's need to be unarchive.
There was a problem hiding this comment.
Understood 👍 we can add tracy/tracy if needed to require-dev. It's good enough for quick dumping
There was a problem hiding this comment.
For note, rectorphp/rector-debugging is archived, if that will be used, that's need to be unarchive.
That's what I want to avoid → less dependencies :) That repository was not a good idea.
TomasVotruba
force-pushed
the
tv-tracy-less
branch
from
bbe9b6c
to
8e47af9
Compare
…kage instead; add local d() and dd() functions
TomasVotruba
force-pushed
the
tv-tracy-less
branch
from
8e47af9
to
54c5357
Compare
|
6 k lines less in the final release 🤙 |
|
If we use rector-debugging in require-dev, that will not included in scoped vendor as well. Using require-dev will still have less dependency to ship if you consider that |
| } | ||
| } | ||
|
|
||
|
|
||
| if (! function_exists('print_node')) { |
There was a problem hiding this comment.
print_node() call Dumper::dump($printedContent); that will error without tracy, the dump print content may just be replaced with var_dump
Instead of shipping tracy with every Rector build, we should use debug tools only in dev code.
Not everyone wants to debug Rector, and not everyone want to use tracy :) we should let people use their own debug functions/tools, if they needed.