-
-
Notifications
You must be signed in to change notification settings - Fork 347
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DeadCode] Handle duplicated annotation on space before close parentheses on RemoveUselessParamTagRector #4795
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It seems cause error on rector-doctrine test: There was 1 failure:
1) Rector\Doctrine\Tests\Set\DoctrineORM29Set\Php81NestedAttributesTest::test with data set #1
Failed on fixture file "overrides.php.inc"
Failed asserting that string matches format description.
--- Expected
+++ Actual
@@ @@
use Doctrine\ORM\Mapping as ORM;
#[ORM\AssociationOverrides([new ORM\AssociationOverride(name: 'propertyA', inversedBy: 'propertyB')])]
-#[ORM\AttributeOverrides([new ORM\AttributeOverride(name: 'id', column: new ORM\Column(type: 'integer'))])] I will look more... |
Fixed 🎉 /cc @mkrauss |
Oh, it cause another error: There was 1 failure:
1) Rector\Tests\BetterPhpDocParser\PhpDocParser\TagValueNodeReprint\TagValueNodeReprintTest::test with data set #29
Failed asserting that two strings are identical.
--- Expected
+++ Actual
@@ @@
* )
*
* @SWG\Definition(required={"id", "created", "modified", "status", "progress", "completed"})
+ * @SWG\Definition(required={"id", "created", "modified", "status", "progress", "completed"}) I will look moreeee. |
@TomasVotruba fixed 🎉 |
Finally 🎉 🎉 🎉 All checks have passed 🎉 @TomasVotruba I think it is ready. |
@TomasVotruba let's merge it to have faster feedback to test ;) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4641
Closes rectorphp/rector#8101