Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DeadCode] Handle duplicated annotation on space before close parentheses on RemoveUselessParamTagRector #4795

Merged
merged 7 commits into from
Aug 15, 2023

Conversation

samsonasik
Copy link
Member

@samsonasik
Copy link
Member Author

It seems cause error on rector-doctrine test:

There was 1 failure:

1) Rector\Doctrine\Tests\Set\DoctrineORM29Set\Php81NestedAttributesTest::test with data set #1
Failed on fixture file "overrides.php.inc"
Failed asserting that string matches format description.
--- Expected
+++ Actual
@@ @@
 use Doctrine\ORM\Mapping as ORM;
 
 #[ORM\AssociationOverrides([new ORM\AssociationOverride(name: 'propertyA', inversedBy: 'propertyB')])]
-#[ORM\AttributeOverrides([new ORM\AttributeOverride(name: 'id', column: new ORM\Column(type: 'integer'))])]

I will look more...

@samsonasik
Copy link
Member Author

Fixed 🎉 /cc @mkrauss

@samsonasik
Copy link
Member Author

Oh, it cause another error:

There was 1 failure:

1) Rector\Tests\BetterPhpDocParser\PhpDocParser\TagValueNodeReprint\TagValueNodeReprintTest::test with data set #29
Failed asserting that two strings are identical.
--- Expected
+++ Actual
@@ @@
  * )
  *
  * @SWG\Definition(required={"id", "created", "modified", "status", "progress", "completed"})
+ * @SWG\Definition(required={"id", "created", "modified", "status", "progress", "completed"})

I will look moreeee.

@samsonasik
Copy link
Member Author

@TomasVotruba fixed 🎉

@samsonasik
Copy link
Member Author

Finally 🎉 🎉 🎉 All checks have passed 🎉 @TomasVotruba I think it is ready.

@samsonasik
Copy link
Member Author

@TomasVotruba let's merge it to have faster feedback to test ;)

@samsonasik samsonasik merged commit 83fdfb3 into main Aug 15, 2023
45 checks passed
@samsonasik samsonasik deleted the close-4641 branch August 15, 2023 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incorrect behavior of RemoveUselessParamTagRector
2 participants