Fix annotation to attribute parsing string

config/set/php83.php

@@ -1,14 +1,11 @@
 <?php
 
 declare(strict_types=1);
-use Rector\Php83\Rector\ClassMethod\AddOverrideAttributeToOverriddenMethodsRector;
-use Rector\Php83\Rector\ClassConst\AddTypeToConstRector;
 
 use Rector\Config\RectorConfig;
+use Rector\Php83\Rector\ClassConst\AddTypeToConstRector;
+use Rector\Php83\Rector\ClassMethod\AddOverrideAttributeToOverriddenMethodsRector;
 
 return static function (RectorConfig $rectorConfig): void {
-    $rectorConfig->rules([
-        AddOverrideAttributeToOverriddenMethodsRector::class,
-        AddTypeToConstRector::class,
-    ]);
+    $rectorConfig->rules([AddOverrideAttributeToOverriddenMethodsRector::class, AddTypeToConstRector::class]);
 };

packages-tests/BetterPhpDocParser/PhpDocParser/StaticDoctrineAnnotationParser/Source/StringAnnotationValue.php

@@ -0,0 +1,17 @@
+<?php
+
+declare(strict_types=1);
+
+
+namespace Rector\Tests\BetterPhpDocParser\PhpDocParser\StaticDoctrineAnnotationParser\Source;
+
+class StringAnnotationValue
+{
+    /**
+     * @CustomAnnotation(description="List of value:
+     *  - <b>TRY</b>: To try
+     *  - <b>TEST</b>: to test (Default if no parameters given)")
+     */
+    public function test()
+    {}
+}

packages/BetterPhpDocParser/PhpDocParser/StaticDoctrineAnnotationParser/PlainValueParser.php

@@ -65,12 +65,7 @@ public function parseValue(
             return $constExprNode;
         }
 
-        while ($tokenIterator->isCurrentTokenType(Lexer::TOKEN_DOUBLE_COLON) ||
-            $tokenIterator->isCurrentTokenType(Lexer::TOKEN_IDENTIFIER)
-        ) {
-            $currentTokenValue .= $tokenIterator->currentTokenValue();
-            $tokenIterator->next();
-        }
+        $currentTokenValue = $this->parseStringValue($tokenIterator, $currentTokenValue);
 
         // nested entity!, supported in attribute since PHP 8.1
         if ($tokenIterator->isCurrentTokenType(Lexer::TOKEN_OPEN_PARENTHESES)) {
@@ -98,6 +93,59 @@ public function parseValue(
         return $currentTokenValue;
     }
 
+    private function parseStringValue(BetterTokenIterator $tokenIterator, string $currentTokenValue): string
+    {
+        if (
+            // start with a quote but doesn't end with one
+            (str_starts_with($currentTokenValue, '"') && ! str_ends_with($currentTokenValue, '"'))
+        ) {
+            $currentTokenValue = $this->parseMultilineOrWhiteSpacedString($tokenIterator, $currentTokenValue);
+        } else {
+            while ($tokenIterator->isCurrentTokenType(Lexer::TOKEN_DOUBLE_COLON) ||
+                $tokenIterator->isCurrentTokenType(Lexer::TOKEN_IDENTIFIER)
+            ) {
+                $currentTokenValue .= $tokenIterator->currentTokenValue();
+                $tokenIterator->next();
+            }
+        }
+
+        return $currentTokenValue;
+    }
+
+    private function parseMultilineOrWhiteSpacedString(
+        BetterTokenIterator $tokenIterator,
+        string $currentTokenValue
+    ): string {
+        while (str_starts_with($currentTokenValue, '"') && ! str_ends_with($currentTokenValue, '"')) {
+            if (! $tokenIterator->isCurrentTokenType(Lexer::TOKEN_PHPDOC_EOL)) {
+                $currentTokenValue .= ' ';
+            }
+
+            if (str_starts_with($currentTokenValue, '"') && str_contains(
+                $tokenIterator->currentTokenValue(),
+                '"'
+            ) && $currentTokenValue !== $tokenIterator->currentTokenValue()) {
+                //starts with '"' and current token contains '"', should be the end
+                $currentTokenValue .= substr(
+                    $tokenIterator->currentTokenValue(),
+                    0,
+                    ((int) strpos($tokenIterator->currentTokenValue(), '"') + 1)
+                );
+                $tokenIterator->next();
+                break;
+            }
+
+            $currentTokenValue .= $tokenIterator->currentTokenValue();
+            $tokenIterator->next();
+        }
+
+        if (str_starts_with($currentTokenValue, '"') && str_ends_with($currentTokenValue, '"')) {
+            return trim(str_replace('"', '', $currentTokenValue));
+        }
+
+        return $currentTokenValue;
+    }
+
     private function parseNestedDoctrineAnnotationTagValueNode(
         string $currentTokenValue,
         BetterTokenIterator $tokenIterator,

rector.php

@@ -4,7 +4,6 @@
 
 use Rector\CodingStyle\Rector\String_\UseClassKeywordForClassNameResolutionRector;
 use Rector\Config\RectorConfig;
-
 use Rector\Core\Collector\MockedClassCollector;
 use Rector\Core\Collector\ParentClassCollector;
 use Rector\DeadCode\Rector\ConstFetch\RemovePhpVersionIdCheckRector;

rules-tests/Php83/Rector/ClassConst/AddTypeToConstRector/config/configured_rule.php

@@ -1,10 +1,10 @@
 <?php
 
 declare(strict_types=1);
-use Rector\Php83\Rector\ClassConst\AddTypeToConstRector;
 
 use Rector\Config\RectorConfig;
 use Rector\Core\ValueObject\PhpVersion;
+use Rector\Php83\Rector\ClassConst\AddTypeToConstRector;
 
 return static function (RectorConfig $rectorConfig): void {
     $rectorConfig->rule(AddTypeToConstRector::class);

rules-tests/Renaming/Rector/Name/RenameClassRector/config/configured_rule.php

@@ -4,7 +4,6 @@
 
 use Acme\Bar\DoNotUpdateExistingTargetNamespace;
 use Rector\Config\RectorConfig;
-
 use Rector\Renaming\Rector\Name\RenameClassRector;
 use Rector\Tests\Renaming\Rector\Name\RenameClassRector\Fixture\DuplicatedClass;
 use Rector\Tests\Renaming\Rector\Name\RenameClassRector\Source\Contract\FirstInterface;

rules/Php83/Rector/ClassConst/AddTypeToConstRector.php

@@ -4,19 +4,19 @@
 
 namespace Rector\Php83\Rector\ClassConst;
 
-use PhpParser\Node\Stmt\ClassConst;
-use PhpParser\Node\Identifier;
+use PhpParser\Node;
 use PhpParser\Node\Const_;
 use PhpParser\Node\Expr;
-use PhpParser\Node\Scalar\String_;
-use PhpParser\Node\Scalar\LNumber;
-use PhpParser\Node\Scalar\DNumber;
-use PhpParser\Node\Expr\ConstFetch;
 use PhpParser\Node\Expr\Array_;
+use PhpParser\Node\Expr\ConstFetch;
+use PhpParser\Node\Identifier;
 use PhpParser\Node\Name;
-use PhpParser\Node;
 use PhpParser\Node\Name\FullyQualified;
+use PhpParser\Node\Scalar\DNumber;
+use PhpParser\Node\Scalar\LNumber;
+use PhpParser\Node\Scalar\String_;
 use PhpParser\Node\Stmt\Class_;
+use PhpParser\Node\Stmt\ClassConst;
 use PHPStan\Reflection\ClassReflection;
 use PHPStan\Reflection\MissingConstantFromReflectionException;
 use PHPStan\Reflection\ReflectionProvider;
@@ -73,7 +73,7 @@ public function refactor(Node $node): Class_|null
             return null;
         }
 
-        $consts = array_filter($node->stmts, static fn(Node $node): bool => $node instanceof ClassConst);
+        $consts = array_filter($node->stmts, static fn (Node $node): bool => $node instanceof ClassConst);
 
         if ($consts === []) {
             return null;
@@ -107,7 +107,7 @@ public function refactor(Node $node): Class_|null
                 $valueType = $this->findValueType($constNode->value);
             }
 
-            if (!($valueType ?? null) instanceof Identifier) {
+            if (! ($valueType ?? null) instanceof Identifier) {
                 continue;
             }
 

rules/Strict/NodeFactory/ExactCompareFactory.php

@@ -40,10 +40,7 @@ public function createIdenticalFalsyCompare(
                 return new Identical($expr, new String_(''));
             }
 
-            return new BooleanOr(
-                new Identical($expr, new String_('')),
-                new Identical($expr, new String_('0'))
-            );
+            return new BooleanOr(new Identical($expr, new String_('')), new Identical($expr, new String_('0')));
         }
 
         if ($exprType->isInteger()->yes()) {

tests/Issues/ConstructorPromoAnnotationToAttribute/config/configured_rule.php

@@ -3,7 +3,6 @@
 declare(strict_types=1);
 
 use Rector\Config\RectorConfig;
-
 use Rector\Php80\Rector\Class_\AnnotationToAttributeRector;
 use Rector\Php80\Rector\Class_\ClassPropertyAssignToConstructorPromotionRector;
 use Rector\Php80\ValueObject\AnnotationToAttribute;

tests/Issues/PlainValueParser/Fixture/fixture.php.inc

@@ -0,0 +1,35 @@
+<?php
+
+namespace Rector\Core\Tests\Issues\PlainValueParser\Fixture;
+
+use Rector\Core\Tests\Issues\PlainValueParser\Source\CustomAnnotation;
+
+final class SomeFixture
+{
+    /**
+     * @CustomAnnotation(description="List of value:
+     *  - <b>TRY</b>: To try
+     *  - <b>TEST</b>: to test (Default if no parameters given)")
+     */
+    public function test()
+    {}
+}
+
+?>
+-----
+<?php
+
+namespace Rector\Core\Tests\Issues\PlainValueParser\Fixture;
+
+use Rector\Core\Tests\Issues\PlainValueParser\Source\CustomAnnotation;
+
+final class SomeFixture
+{
+    #[CustomAnnotation(description: 'List of value :
+  - < b > TRY < /b>: To try
+  - < b > TEST < /b>: to test ( Default if no parameters given )')]
+    public function test()
+    {}
+}
+
+?>

tests/Issues/PlainValueParser/PlainValueParserTest.php

@@ -0,0 +1,28 @@
+<?php
+
+declare(strict_types=1);
+
+namespace Rector\Core\Tests\Issues\PlainValueParser;
+
+use Iterator;
+use PHPUnit\Framework\Attributes\DataProvider;
+use Rector\Testing\PHPUnit\AbstractRectorTestCase;
+
+final class PlainValueParserTest extends AbstractRectorTestCase
+{
+    #[DataProvider('provideData')]
+    public function test(string $filePath): void
+    {
+        $this->doTestFile($filePath);
+    }
+
+    public static function provideData(): Iterator
+    {
+        return self::yieldFilesFromDirectory(__DIR__ . '/Fixture');
+    }
+
+    public function provideConfigFilePath(): string
+    {
+        return __DIR__ . '/config/configured_rule.php';
+    }
+}

tests/Issues/PlainValueParser/Source/CustomAnnotation.php

@@ -0,0 +1,10 @@
+<?php
+
+namespace Rector\Core\Tests\Issues\PlainValueParser\Source;
+
+class CustomAnnotation
+{
+    public function __construct(public string $description)
+    {
+    }
+}

tests/Issues/PlainValueParser/config/configured_rule.php

@@ -0,0 +1,14 @@
+<?php
+
+declare(strict_types=1);
+
+use Rector\Config\RectorConfig;
+use Rector\Core\Tests\Issues\PlainValueParser\Source\CustomAnnotation;
+use Rector\Php80\Rector\Class_\AnnotationToAttributeRector as AnnotationToAttributeRectorAlias;
+use Rector\Php80\ValueObject\AnnotationToAttribute;
+
+return static function (RectorConfig $rectorConfig): void {
+    $rectorConfig->ruleWithConfiguration(AnnotationToAttributeRectorAlias::class, [
+        new AnnotationToAttribute(CustomAnnotation::class),
+    ]);
+};