-
-
Notifications
You must be signed in to change notification settings - Fork 344
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allows to convert Spatie enum names to snake upper case #5435
Allows to convert Spatie enum names to snake upper case #5435
Conversation
Could you tell me what the best way to test the rule with If I understand correctly naming convention makes it so that we can have only one test class for Ideas? Thanks! |
rules-tests/Php81/Rector/Class_/SpatieEnumClassToEnumRector/Fixture/some_class.php.inc
Outdated
Show resolved
Hide resolved
Only "ready" PRs trigger the CI, not drafts. So I took the liberty and triggered CI so we have more feedback |
Could you also rebase on the |
…erSnakeCase configuration
- rebase main
a0aad71
to
222c8bc
Compare
Alright, merge conflicts are fixed and I moved upper case names to a new test fixture. Original tests are green so BC is ensured. ps: |
Looks good, thank you 👍 |
Hi.
This PR addresses issue rectorphp/rector#8364 and lets you convert Spatie enum names to upper snake case.