Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DowngradePhp72] Skip implements built in interface method on DowngradeParameterTypeWideningRector #766

Merged
merged 9 commits into from
Aug 26, 2021
Merged

[DowngradePhp72] Skip implements built in interface method on DowngradeParameterTypeWideningRector #766

merged 9 commits into from
Aug 26, 2021

Conversation

samsonasik
Copy link
Member

@samsonasik samsonasik commented Aug 25, 2021 •
edited
Loading

@samsonasik samsonasik mentioned this pull request Aug 25, 2021
Closed
@samsonasik
Copy link
Member Author

All checks have passed 🎉 @TomasVotruba it is ready for review.

@samsonasik
Copy link
Member Author

indirect implements native interface should be allowed, added handling for it.

@TomasVotruba TomasVotruba merged commit 47ad54d into main Aug 26, 2021
@TomasVotruba TomasVotruba deleted the close-761 branch August 26, 2021 07:51
@TomasVotruba
Copy link
Member

Thank you 👏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Incorrect behavior of DowngradeParameterTypeWideningRector
3 participants
@samsonasik @TomasVotruba @bobab12