Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CodingStyle] Handle null item on ManualJsonStringToJsonEncodeArrayRector #791

Merged
merged 3 commits into from
Aug 30, 2021

Conversation

samsonasik
Copy link
Member

@samsonasik samsonasik commented Aug 30, 2021

Given the following code:

$json = '{"a":null}';

It got error:

1) Rector\Tests\CodingStyle\Rector\Assign\ManualJsonStringToJsonEncodeArrayRector\ManualJsonStringToJsonEncodeArrayRectorTest::test with data set #0 (Symplify\SmartFileSystem\SmartFileInfo Object (...))
Rector\Core\Exception\NotImplementedYetException: Not implemented yet. Go to "Rector\Core\PhpParser\Node\NodeFactory::createArrayItem()" and add check for "" node.

This patch fix it .

@samsonasik samsonasik force-pushed the handle-null-item-manualjsonstring-to-json-encode branch from 123ab2a to b3c9938 Compare August 30, 2021 15:50
@samsonasik
Copy link
Member Author

All checks have passed 🎉 @TomasVotruba it is ready for review.

@TomasVotruba TomasVotruba merged commit ec7c68f into main Aug 30, 2021
@TomasVotruba TomasVotruba deleted the handle-null-item-manualjsonstring-to-json-encode branch August 30, 2021 16:10
@TomasVotruba
Copy link
Member

Thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants