[Symfony] Guzzle to HttpClient

[TomasVotruba]

Ref:

• https://symfony.com/blog/new-in-symfony-4-3-httpclient-component
• https://medium.com/@andreiabohner/symfony-4-3-httpclient-cheat-sheet-fbf695df12eb

[stloyd]

Replacing automatically Guzzle may be hard/impossible, mostly cause it allows creating middlewares etc. so it's really split along the codebase.

Personally I would probably vote for replacing file_get_contents('http(s)://') etc. calls to that new client.

[TomasVotruba]

Replacing automatically Guzzle may be hard/impossible, mostly cause it allows creating middlewares etc. so it's really split along the codebase.

That's a challange then :) the point is to automate whan can be automized.

Personally I would probably vote for replacing file_get_contents('http(s)://') etc. calls to that new client.

I'm not sure what you mean. Could you share a diff?

[stloyd]

I.e. from:

$data = file_get_contents('https://api.github.com/repos/symfony/symfony-docs');

Into:

$response = (HttpClient::create())
    ->request('GET', 'https://api.github.com/repos/symfony/symfony-docs');

$data = $response->getContent();

[stloyd]

Or i.e. POST:

        $result = file_get_contents('https://github.com/', false, stream_context_create(['http' => [
            'method' => 'POST',
            'header' => 'Content-type: application/x-www-form-urlencoded',
            'content' => $postData,
        ]]));

Into:

        $result = (HttpClient::create())->request('POST', 'https://github.com/', [
            'body' => $postData,
        ])->getContent();

[TomasVotruba]

I see. So plain PHP to Symfony/HttpClient?

How would the second code would look like with creation of the client?

[stloyd]

Can be exactly same as in first :)

[TomasVotruba]

Does it make sense to create new object per call thought? I don't know how you use it, so I need more examples from you to understand it better

[stloyd]

TBH. I dont really think I have such case currently in code (meaning file_get_* used via HTTP), so those above are more abstraction examples ;)

But for Guzzle, we use it, a lot, but I'm not sure how to help you with example to do some replacement ;)

[TomasVotruba]

Oh, I thought you need it :)
In that case I'm alright

[TomasVotruba]

Closing as too broad, needs specific project