Incorrect behavior of AnnotationToAttributeRector

[marcosemplici]

Bug Report

Subject	Details
Rector version	last dev-master
Installed as	composer dependency

Minimal PHP Code Causing Issue

See https://getrector.org/demo/1ec72cab-b010-69f0-9785-0f4103e3217a

<?php
use ApiPlatform\Core\Annotation\ApiFilter;

/**
 * @ApiFilter(SearchFilter::class,
 *     properties={
 *     "id": "exact",
 *     ActivationRequest::FIRSTNAME : "ipartial",
 * })
 */
class ActivationRequest
{
    public const FIRSTNAME ='firstName';
}

Responsible rules

• AnnotationToAttributeRector

Expected Behavior

[marcosemplici]

RECTOR CHANGED:

use ApiPlatform\Core\Annotation\ApiFilter;

#[ApiFilter(SearchFilter::class, properties: ['id' => 'exact', 0 => ActivationRequest::FIRSTNAME])]
class ActivationRequest
{
    public const FIRSTNAME ='firstName';
}

EXPECTED:

use ApiPlatform\Core\Annotation\ApiFilter;

#[ApiFilter(SearchFilter::class, properties: ['id' => 'exact',  ActivationRequest::FIRSTNAME => 'ipartial'])]
class ActivationRequest
{
    public const FIRSTNAME ='firstName';
}

[TomasVotruba]

Thanks for reporting. Could you check this fix if it fits your use case?
rectorphp/rector-src#1659

[marcosemplici]

Yes it fixs. But there's similar use case...
https://getrector.org/demo/1ec72f1d-35ed-671c-8788-a18acc9c9cfc

[TomasVotruba]

I see. Could you add test fixture with that code in the /Fixture directory?
You can copy this one, just replace class name and nested items: https://github.com/rectorphp/rector-src/pull/1659/files#diff-5a4601bb83345d7f48c1acf8b28e5906e284487015c6ff891b21a8724ae03cbb

[Jean85]

I tried to do it in rectorphp/rector-src#1661

[samsonasik]

I am closing it as resolved at rectorphp/rector-src#1661