Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[EarlyReturn] Add ChangeAndIfContinueToMultiContinueRector #5460

Merged
merged 17 commits into from
Feb 9, 2021
Merged

[EarlyReturn] Add ChangeAndIfContinueToMultiContinueRector #5460

merged 17 commits into from
Feb 9, 2021

Conversation

samsonasik
Copy link
Member

Fixes #5230

@samsonasik samsonasik changed the title [EarlyReturn] [WIP] Add ChangeAndIfContinueToContinueEarlyRector [EarlyReturn] [WIP] Add ChangeAndIfContinueToMultiContinueRector Feb 8, 2021
@samsonasik samsonasik changed the title [EarlyReturn] [WIP] Add ChangeAndIfContinueToMultiContinueRector [EarlyReturn] Add ChangeAndIfContinueToMultiContinueRector Feb 8, 2021
@samsonasik
Copy link
Member Author

samsonasik commented Feb 8, 2021 •
edited
Loading

implemented, also moved re-use functionality for create if negation to IfManipulator service.

@samsonasik
Copy link
Member Author

All checks have passed 🎉 @TomasVotruba it is ready for review.

@samsonasik
Copy link
Member Author

rebased.

@samsonasik
Copy link
Member Author

All checks have passed 🎉 @TomasVotruba it is ready for review.

TomasVotruba
TomasVotruba reviewed Feb 9, 2021
View reviewed changes
src/NodeManipulator/IfManipulator.php Outdated
}

return new BooleanNot($expr);
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might be useful Rector\EarlyReturn\NodeTransformer\ConditionInverter

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

implemented.

@samsonasik
Copy link
Member Author

All checks have passed 🎉 @TomasVotruba I think it is ready.

@samsonasik
Copy link
Member Author

rebased.

@samsonasik
Copy link
Member Author

All checks have passed 🎉 @TomasVotruba I think it is ready.

@TomasVotruba
Copy link
Member

Thank you 👍

@TomasVotruba TomasVotruba merged commit 6b8789e into master Feb 9, 2021
@TomasVotruba TomasVotruba deleted the fix-5230 branch February 9, 2021 19:07
TomasVotruba added a commit that referenced this pull request Jan 13, 2024
@TomasVotruba
Updated Rector to commit 2ec55701f292770fc7be3ca6e434d437e59c333b
8b20f23 
rectorphp/rector-src@2ec5570 [Performance] Fix filter cache on SkippedClassResolver (#5460)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TomasVotruba TomasVotruba TomasVotruba left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[EarlyReturn] Split && if to 2 continues 2
2 participants
@samsonasik @TomasVotruba