Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds support for Subscription#total_billing_cycles #55

Merged
merged 2 commits into from
Jan 26, 2012

Conversation

nhance
Copy link

@nhance nhance commented Jan 26, 2012

In order to specify the number of billing cycles in my request to Recurly, support has been added to the gem.

In addition, there was an error with the dependency on bundler (Asking for a version that doesn't exist), so this resolves that as well.

More information is available from reenhanced#1 with detail on how this code was constructed and the results of our internal code review.

[Closes #1]

Squashed commit of the following:

commit 14b9f4e
Author: Nicholas Hance <nhance@reenhanced.com>
Date:   Thu Jan 26 14:02:15 2012 -0500

    Pull request updates

commit ff25edd
Author: Nicholas Hance <nhance@reenhanced.com>
Date:   Thu Jan 26 13:57:11 2012 -0500

    Support Subscription#total_billing_cycles

commit 7bea3f2
Author: Nicholas Hance <nhance@reenhanced.com>
Date:   Thu Jan 26 13:10:47 2012 -0500

    Tests for ensuring subscription attributes exist

commit 37ec6b5
Author: Nicholas Hance <nhance@reenhanced.com>
Date:   Wed Jan 25 15:56:36 2012 -0500

    Resolves dependency errors, adds better tests for attributs
@stephencelis
Copy link

Thanks!

stephencelis added a commit that referenced this pull request Jan 26, 2012
Adds support for Subscription#total_billing_cycles
@stephencelis stephencelis merged commit aa34e5e into recurly:master Jan 26, 2012
@bhelx bhelx added the V2 V2 Client label Mar 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
V2 V2 Client
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants