Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix merge issue #48

Merged
merged 1 commit into from
Sep 8, 2023
Merged

Fix merge issue #48

merged 1 commit into from
Sep 8, 2023

Conversation

zdtsw
Copy link

@zdtsw zdtsw commented Aug 31, 2023

  • reapply PR #34
  • seems when we apply sync from ODH with big API change, mistakenly reverted this fix for "segment-io" bug
  • csv change is only after re-generate it

@zdtsw
Fix merge issue
93c8c09 
- reapply PR red-hat-data-services#34

Signed-off-by: Wen Zhou <wenzhou@redhat.com>
@zdtsw zdtsw mentioned this pull request Aug 31, 2023
Merged
@zdtsw
Copy link
Author

zdtsw commented Aug 31, 2023

@VaishnaviHire @etirelli still need this one into "main"

VaishnaviHire
VaishnaviHire approved these changes Sep 8, 2023
View reviewed changes
Copy link

@VaishnaviHire VaishnaviHire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@VaishnaviHire VaishnaviHire merged commit 2b19844 into red-hat-data-services:main Sep 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@VaishnaviHire VaishnaviHire VaishnaviHire approved these changes

@etirelli etirelli Awaiting requested review from etirelli

@lugi0 lugi0 Awaiting requested review from lugi0

Assignees
No one assigned
Labels
rhods-1.33
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zdtsw @VaishnaviHire