New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug 1994588: ceph: update CSIDriver object from betav1 to v1 #282
Conversation
Update the CSIDriver object to v1 from betav1 as it will be deprecated in v1.19+ and become unavailable in v1.22+ Signed-off-by: Yug <yuggupta27@gmail.com> (cherry picked from commit d513dc4)
Hi @Yuggupta27. Thanks for your PR. I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@Yuggupta27: This pull request references Bugzilla bug 1994588, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/hold |
/ok-to-test |
rook#8582 also need to be backported along with this PR |
@agarwal-mudit considerig panic/dependency PR has merged, this is good to go. |
Sorry, we have to wait as the backport PRs are not merged yet.. |
/hold cancel |
/bugzilla refresh |
@agarwal-mudit: This pull request references Bugzilla bug 1994588, which is valid. 3 validation(s) were run on this bug
No GitHub users were found matching the public email listed for the QA contact in Bugzilla (pbalogh@redhat.com), skipping review request. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@Yuggupta27 We can create a backport PR for rook#8582 now |
Sure, will send it shortly. |
PR rook#8582 depends on the changes in this PR. Due to this, we can backport it as soon as this PR gets merged 👍 |
/lgtm |
/approve |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: leseb, Yuggupta27 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@Yuggupta27: All pull requests linked via external trackers have merged: Bugzilla bug 1994588 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Update the CSIDriver object to v1 from betav1 as it will be
deprecated in v1.19+ and become unavailable in v1.22+
Signed-off-by: Yug yuggupta27@gmail.com
(cherry picked from commit d513dc4)
Description of your changes:
Which issue is resolved by this Pull Request:
Resolves #
Checklist:
make codegen
) has been run to update object specifications, if necessary.