Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 1994588: ceph: update CSIDriver object from betav1 to v1 #282

Merged
merged 1 commit into from Aug 31, 2021

Conversation

Yuggupta27
Copy link

Update the CSIDriver object to v1 from betav1 as it will be
deprecated in v1.19+ and become unavailable in v1.22+

Signed-off-by: Yug yuggupta27@gmail.com
(cherry picked from commit d513dc4)

Description of your changes:

Which issue is resolved by this Pull Request:
Resolves #

Checklist:

  • Commit Message Formatting: Commit titles and messages follow guidelines in the developer guide.
  • Skip Tests for Docs: Add the flag for skipping the build if this is only a documentation change. See here for the flag.
  • Skip Unrelated Tests: Add a flag to run tests for a specific storage provider. See test options.
  • Reviewed the developer guide on Submitting a Pull Request
  • Documentation has been updated, if necessary.
  • Unit tests have been added, if necessary.
  • Integration tests have been added, if necessary.
  • Pending release notes updated with breaking and/or notable changes, if necessary.
  • Upgrade from previous release is tested and upgrade user guide is updated, if necessary.
  • Code generation (make codegen) has been run to update object specifications, if necessary.

Update the CSIDriver object to v1 from betav1 as it will be
deprecated in v1.19+ and become unavailable in v1.22+

Signed-off-by: Yug <yuggupta27@gmail.com>
(cherry picked from commit d513dc4)
@openshift-ci openshift-ci bot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Aug 18, 2021
@openshift-ci
Copy link

openshift-ci bot commented Aug 18, 2021

Hi @Yuggupta27. Thanks for your PR.

I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@Yuggupta27 Yuggupta27 changed the title ceph: update CSIDriver object from betav1 to v1 Bug 1994588: ceph: update CSIDriver object from betav1 to v1 Aug 18, 2021
@openshift-ci openshift-ci bot added the bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. label Aug 18, 2021
@openshift-ci
Copy link

openshift-ci bot commented Aug 18, 2021

@Yuggupta27: This pull request references Bugzilla bug 1994588, which is invalid:

  • expected the bug to target the "OCS 4.8.1" release, but it targets "OCS 4.8.2" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Bug 1994588: ceph: update CSIDriver object from betav1 to v1

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Aug 18, 2021
@agarwal-mudit
Copy link
Member

/hold

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 18, 2021
@agarwal-mudit
Copy link
Member

/ok-to-test

@openshift-ci openshift-ci bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Aug 18, 2021
@Madhu-1
Copy link
Member

Madhu-1 commented Aug 24, 2021

rook#8582 also need to be backported along with this PR

@humblec
Copy link

humblec commented Aug 25, 2021

@agarwal-mudit considerig panic/dependency PR has merged, this is good to go.

@humblec
Copy link

humblec commented Aug 25, 2021

@agarwal-mudit considerig panic/dependency PR has merged, this is good to go.

Sorry, we have to wait as the backport PRs are not merged yet..

@agarwal-mudit
Copy link
Member

/hold cancel

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 30, 2021
@agarwal-mudit
Copy link
Member

/bugzilla refresh

@openshift-ci openshift-ci bot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Aug 30, 2021
@openshift-ci
Copy link

openshift-ci bot commented Aug 30, 2021

@agarwal-mudit: This pull request references Bugzilla bug 1994588, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (OCS 4.8.2) matches configured target release for branch (OCS 4.8.2)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

No GitHub users were found matching the public email listed for the QA contact in Bugzilla (pbalogh@redhat.com), skipping review request.

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot removed the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Aug 30, 2021
@agarwal-mudit
Copy link
Member

@Yuggupta27 We can create a backport PR for rook#8582 now

@Yuggupta27
Copy link
Author

@Yuggupta27 We can create a backport PR for rook#8582 now

Sure, will send it shortly.

@Yuggupta27
Copy link
Author

PR rook#8582 depends on the changes in this PR. Due to this, we can backport it as soon as this PR gets merged 👍

@agarwal-mudit
Copy link
Member

@travisn @leseb This PR can be merged, needs approve/lgtm labels.

@leseb
Copy link

leseb commented Aug 31, 2021

/lgtm

@leseb
Copy link

leseb commented Aug 31, 2021

/approve

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Aug 31, 2021
@leseb leseb merged commit e9a7b8f into red-hat-storage:release-4.8 Aug 31, 2021
@openshift-ci
Copy link

openshift-ci bot commented Aug 31, 2021

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: leseb, Yuggupta27

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci
Copy link

openshift-ci bot commented Aug 31, 2021

@Yuggupta27: All pull requests linked via external trackers have merged:

Bugzilla bug 1994588 has been moved to the MODIFIED state.

In response to this:

Bug 1994588: ceph: update CSIDriver object from betav1 to v1

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test.
Projects
None yet
5 participants