Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds info message when using percona migrator #31

Closed
wants to merge 2 commits into from
Closed

Adds info message when using percona migrator #31

wants to merge 2 commits into from

Conversation

trecenti
Copy link

As a ActiveRecord user
I want to see when PerconaMigrator is being used
So that I know my migrations will use PerconaMigrator

I've added this simple logging every time the logger is created to notify users when Percona Migrator is being used instead of the default one.

@sauloperez
Copy link
Contributor

sauloperez commented Sep 13, 2016

Thanks for contributing @trecenti ! I like it but I think it's better if you use the particular instance of logger after its instantiated: https://github.com/redbooth/percona_migrator/blob/8280285382f358768df9636fdb6673f2681997a0/lib/active_record/connection_adapters/percona_adapter.rb#L15

I guess you want to notify about the use of the migrator as early as possible. In that case, logging the message before instantiating the PerconaMigratorAdapter seems a good place.

@trecenti
Copy link
Author

I guess you want to notify about the use of the migrator as early as possible. In that case, logging the message before instantiating the PerconaMigratorAdapter seems a good place.

That sounds good, I will do this changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants