Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor version release request #32

Closed
trecenti opened this issue Sep 13, 2016 · 7 comments
Closed

Minor version release request #32

trecenti opened this issue Sep 13, 2016 · 7 comments

Comments

@trecenti
Copy link

trecenti commented Sep 13, 2016

Hi folks,

I've been planning to add PerconaMigrator gem to our project and we noticed that the latest released gem v0.1.0.rc.6 does not have stdout logging implemented, I've though noticed that it was recently merged into master, here's a comparison since last release:
v0.1.0.rc.6...master

I was wondering if we could bump a minor version and release so we could benefit from the logging.

@sauloperez if we can make this release, it wouldn't need to add a general logging for whether PerconaMigrator is being used, making #31 not needed.

@sauloperez
Copy link
Contributor

Sure we will. I'm afraid though that that's not enough as pt-online-schema-change, the underlying binary that gets executed, outputs in a streaming fashion. So to show its output as it happens, we'll need read by lines and log them as they become available.

I'll investigate it today and I let you know.

@trecenti
Copy link
Author

I've done some testing with master and it is outputting pt-online-schema-change stdout when I run db:migrate which is what we're looking for.

@sauloperez
Copy link
Contributor

Then, if it's enough for you we can release a new version. I'll get to it later.

@trecenti
Copy link
Author

I'll get to it later.

Thanks, let me know if you need me to do anything, and feel free to close this when you're done.

@sauloperez
Copy link
Contributor

Done! I just released version 0.1.0.rc.7 👌

@trecenti
Copy link
Author

Done! I just released version 0.1.0.rc.7 👌

Thanks @sauloperez

@sauloperez
Copy link
Contributor

FYI @trecenti #33

etagwerker pushed a commit to etagwerker/departure that referenced this issue Mar 6, 2020
Prevent overriding default rails connection_specification_name ("primary")
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants