Add support for React 15 #279
Conversation
| @@ -5,7 +5,7 @@ export default class IndexPage { | |||
| getElements() { | |||
| return <div> | |||
| <h1>Entrypoints:</h1> | |||
| <ul>{_.map(entrypoints, (val, key) => <li> | |||
| <ul>{_.map(entrypoints, (val, key) => <li key={key}> | |||
There was a problem hiding this comment.
Just hushing some old warnings while I looked for new errors.
|
🚀 ✨ ❤️ 👍 🚢 |
|
It'd be awesome to have this merged in and a npm release cut! If only to silence npm's complaints. :) |
|
Look at all these nice things! https://github.com/facebook/react/releases/tag/v15.3.1 We could have them all! |
|
Would be so great to have this merged. |
|
Okay, we need to get this done. I've rebased and pointed this at master. Ready to merge once the next version goes out. |
|
@gigabo it would be really great to be able to use https://facebook.github.io/react/blog/2016/11/16/react-v15.4.0.html#profiling-components-with-chrome-timeline . Let's merge this stat -- I'm willing to do a dedicated release just for this one pr. |
| @@ -39,8 +39,8 @@ | |||
| "winston": "2.2.0" | |||
| }, | |||
| "peerDependencies": { | |||
| "react": "~0.14.2", | |||
| "react-dom": "~0.14.2", | |||
| "react": "^15.1.0", | |||
There was a problem hiding this comment.
Is it possible to target ~0.14.2 || ^15.1.0? That will let users still on react 0.14 catch up
There was a problem hiding this comment.
Oh, that's a good idea! 🤔
There was a problem hiding this comment.
might actually make it easier for you guys to manage your upgrade as well
There was a problem hiding this comment.
Yeah, definitely. Good idea @auskast!
Due to https://facebook.github.io/react/tips/children-props-type.html: > when there is only a single child, this.props.children will be the single > child component itself without the array wrapper. This saves an array > allocation.
Just eliminating a warning
|
Okay, I've rebased and changed to support both 0.14 and 15 as suggested by @auskast. Going to remove the |
|
React 15 support is now available in |
This was suspiciously easy...
This addresses #81.
Targetingnext, here. It's a breaking change.