Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add estimate time to review PR command and GH action #86

Merged
merged 10 commits into from
Feb 27, 2024
Merged

feat: add estimate time to review PR command and GH action #86

merged 10 commits into from
Feb 27, 2024

Conversation

tnevrlka
Copy link
Contributor

@tnevrlka tnevrlka commented Feb 20, 2024 •
edited
Loading

KONFLUX-2222

Recreated #78

Examples:

@tnevrlka tnevrlka mentioned this pull request Feb 20, 2024
Closed
Dannyb48
Dannyb48 reviewed Feb 20, 2024
View reviewed changes
Copy link
Collaborator

@Dannyb48 Dannyb48 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we want to make sure we document this properly. Like how to use and enable. And more importantly the logic you implemented and the weighted scores you apply to files, etc.

.github/workflows/estimate-review.yml Outdated Show resolved Hide resolved
@tnevrlka tnevrlka force-pushed the estimate-review-time branch 3 times, most recently from 0eb651f to 0fb6761 Compare February 22, 2024 14:44
@tnevrlka tnevrlka marked this pull request as ready for review February 26, 2024 14:17
psturc
psturc reviewed Feb 27, 2024
View reviewed changes
Copy link
Member

@psturc psturc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just a few comments, otherwise lgtm!

.github/workflows/estimate-review.yml Show resolved Hide resolved
cmd/estimate/reviewTime.go Outdated Show resolved Hide resolved
@tnevrlka
feat: add estimate review time command
831641b 
Add command for estimation of the time it takes to review a pull
request.
@tnevrlka
feat: add estimate review action
583178a 
Add GitHub Action for running the time needed for PR review estimation
@tnevrlka
feat: add support for estimation weights in yaml
5a9aead 
- Allow teams to use their own weights for PR review time estimation.
- Teams can add weights for the file extensions they use
@tnevrlka
feat: add optional GitHub authentication
02562ba 
Add optional GitHub authentication via a token to avoid API rate
limiting
@tnevrlka
feat: label PRs in the estimate-review command
9874a13 
- Move labeling logic from GitHub Actions to the command
- Automatically check for and delete outdated labels
- Ability to create new custom labels in the yaml config file
@tnevrlka
feat: allow commit and files weights config
6ae3785
@tnevrlka
feat: handle custom default file extension weights
3fa5eb5
@tnevrlka
docs: add estimate-review documentation
1fc82c7
@tnevrlka
chore: add build step to GH Action
8a367f1
@tnevrlka
feat: use viper config in estimate-review
9f04c00
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Feb 27, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@tnevrlka tnevrlka requested a review from psturc February 27, 2024 12:39
@tnevrlka tnevrlka merged commit c0eaf79 into main Feb 27, 2024
8 checks passed
Dannyb48
Dannyb48 approved these changes Feb 27, 2024
View reviewed changes
Copy link
Collaborator

@Dannyb48 Dannyb48 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@psturc psturc deleted the estimate-review-time branch February 27, 2024 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Dannyb48 Dannyb48 Dannyb48 approved these changes

@psturc psturc psturc approved these changes

Assignees
No one assigned
Labels
15-30 min
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tnevrlka @psturc @Dannyb48